Don't blindly do a prefix match when evaluating net::GetExtensionsForMimeType().

Don't blindly do a prefix match when evaluating net::GetExtensionsForMimeType().

BUG=685932
Review-Url: https://codereview.chromium.org/2665953002
Cr-Commit-Position: refs/heads/master@{#447290}
Committed: https://chromium.googlesource.com/chromium/src/+/f6ef68261dc24e0500a99439575fdd9feeb712a6

[eroman, 2017-01-30 23:47:29]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 23:47:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-01-30 23:48:50]

eroman@chromium.org changed reviewers:
+ xunjieli@chromium.org

[commit-bot: I haz the power, 2017-01-31 00:37:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 00:37:57]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[eroman, 2017-01-31 02:41:22]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 02:41:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 04:06:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 04:06:51]

Dry run: This issue passed the CQ dry run.

[xunjieli, 2017-01-31 17:21:29]

lgtm. Very neat!

https://codereview.chromium.org/2665953002/diff/20001/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/2665953002/diff/20001/net/base/mime_util.cc#n...
net/base/mime_util.cc:463: void GetExtensionsFromHardCodedMappings(
nit: Could you add a comment on this function? (highlight the relationship
between |prefix_match| and |mime_type|)

[eroman, 2017-01-31 17:41:30]

Thanks for the review!

https://codereview.chromium.org/2665953002/diff/20001/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/2665953002/diff/20001/net/base/mime_util.cc#n...
net/base/mime_util.cc:463: void GetExtensionsFromHardCodedMappings(
On 2017/01/31 17:21:29, xunjieli wrote:
> nit: Could you add a comment on this function? (highlight the relationship
> between |prefix_match| and |mime_type|)

Done, good idea.

[eroman, 2017-01-31 17:43:21]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 17:43:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-01-31 18:14:12]

On 2017/01/31 17:41:30, eroman (slow) wrote:
> Thanks for the review!
> 
> https://codereview.chromium.org/2665953002/diff/20001/net/base/mime_util.cc
> File net/base/mime_util.cc (right):
> 
>
https://codereview.chromium.org/2665953002/diff/20001/net/base/mime_util.cc#n...
> net/base/mime_util.cc:463: void GetExtensionsFromHardCodedMappings(
> On 2017/01/31 17:21:29, xunjieli wrote:
> > nit: Could you add a comment on this function? (highlight the relationship
> > between |prefix_match| and |mime_type|)
> 
> Done, good idea.

lgtm. thanks.

[commit-bot: I haz the power, 2017-01-31 18:55:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 18:55:49]

Dry run: This issue passed the CQ dry run.

[eroman, 2017-01-31 18:59:31]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:00:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 19:12:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485889171702880,
"parent_rev": "1a5f2851a8a4cf5222a676dc8bcc7d52fc29a7f1", "commit_rev":
"f6ef68261dc24e0500a99439575fdd9feeb712a6"}

[commit-bot: I haz the power, 2017-01-31 19:12:45]

Description was changed from

==========
Don't blindly do a prefix match when evaluating net::GetExtensionsForMimeType().

BUG=685932
==========

to

==========
Don't blindly do a prefix match when evaluating net::GetExtensionsForMimeType().

BUG=685932

Review-Url: https://codereview.chromium.org/2665953002
Cr-Commit-Position: refs/heads/master@{#447290}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6ef68261dc24e0500a99439575f...
==========

[commit-bot: I haz the power, 2017-01-31 19:12:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f6ef68261dc24e0500a99439575f...