Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2665863002: [css-grid] Clamp the number of auto-repeat tracks (Closed)

Created:
3 years, 10 months ago by Manuel Rego
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[css-grid] Clamp the number of auto-repeat tracks The computation of auto-repeat tracks might issue a result larger than the total number of tracks limit. We need to clamp the grid also in those cases. BUG=681381 Review-Url: https://codereview.chromium.org/2657863005 Cr-Commit-Position: refs/heads/master@{#446646} (cherry picked from commit 946f89ab4dfffec7f9d13bac423ca5a0df949bb6) Review-Url: https://codereview.chromium.org/2665863002 . Cr-Commit-Position: refs/branch-heads/2987@{#183} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/4b3f65698baa64b20f07e341c19751803af8be1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-repeat-huge-grid.html View 1 chunk +149 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Manuel Rego
3 years, 10 months ago (2017-01-30 20:49:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b3f65698baa64b20f07e341c19751803af8be1a.

Powered by Google App Engine
This is Rietveld 408576698