Issue 2665863002: [css-grid] Clamp the number of auto-repeat tracks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2665863002: [css-grid] Clamp the number of auto-repeat tracks (Closed)

Created:
3 years, 10 months ago by Manuel Rego

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

[css-grid] Clamp the number of auto-repeat tracks The computation of auto-repeat tracks might issue a result larger than the total number of tracks limit. We need to clamp the grid also in those cases. BUG=681381 Review-Url: https://codereview.chromium.org/2657863005 Cr-Commit-Position: refs/heads/master@{#446646} (cherry picked from commit 946f89ab4dfffec7f9d13bac423ca5a0df949bb6) Review-Url: https://codereview.chromium.org/2665863002 . Cr-Commit-Position: refs/branch-heads/2987@{#183} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/4b3f65698baa64b20f07e341c19751803af8be1a

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -0 lines)			Patch
	A	third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-repeat-huge-grid.html	View		1 chunk	+149 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/layout/LayoutGrid.cpp	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Manuel Rego

3 years, 10 months ago (2017-01-30 20:49:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4b3f65698baa64b20f07e341c19751803af8be1a.