Reapply "Create an app snapshot of the Dart front end."

Reapply "Create an app snapshot of the Dart front end."

Skip training on Windows, issue #28532.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/9eb216a495f8917ba1bcc55d2555d8203a76c09f

[rmacnak, 2017-01-30 17:02:45]

rmacnak@google.com changed reviewers:
+ hausner@google.com

[rmacnak, 2017-01-30 17:02:45]

https://codereview.chromium.org/2665753002/diff/1/utils/kernel-service/kernel...
File utils/kernel-service/kernel-service.dart (right):

https://codereview.chromium.org/2665753002/diff/1/utils/kernel-service/kernel...
utils/kernel-service/kernel-service.dart:102: if (Platform.isWindows) return;
Change versus last time is here.

[rmacnak, 2017-01-30 19:52:07]

+cc Slava

From source
./out/ReleaseX64/dart --dfe=utils/kernel-service/kernel-service.dart
~/hello.dart

From snapshot
./out/ReleaseX64/dart --dfe=out/ReleaseX64/gen/kernel-service.dart.snapshot
~/hello.dart

[rmacnak, 2017-01-31 01:53:37]

Sync'd and fixed infinite loop.

https://codereview.chromium.org/2665753002/diff/20001/utils/kernel-service/ke...
File utils/kernel-service/kernel-service.dart (left):

https://codereview.chromium.org/2665753002/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:219: if (dir.parent == dir) {
This is always true. dart.io.Directory are only equal if they are identical, not
if they have the same path/inode/etc.

[hausner, 2017-01-31 03:53:29]

LGTM.

[Vyacheslav Egorov (Google), 2017-01-31 06:18:01]

vegorov@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2017-01-31 06:18:02]

https://codereview.chromium.org/2665753002/diff/20001/utils/kernel-service/ke...
File utils/kernel-service/kernel-service.dart (left):

https://codereview.chromium.org/2665753002/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:219: if (dir.parent == dir) {
On 2017/01/31 01:53:37, rmacnak wrote:
> This is always true. dart.io.Directory are only equal if they are identical,
not
> if they have the same path/inode/etc.

This code was copied from the Loader code so it has the same bug. The reason why
this code is written like this is because we have the following comment for the
parent:

  /**
   * The directory containing [this].  If [this] is a root
   * directory, returns [this].
   */

But implementation does not actually follow the comment :-/

[Vyacheslav Egorov (Google), 2017-01-31 07:32:22]

https://codereview.chromium.org/2665753002/diff/20001/utils/kernel-service/ke...
File utils/kernel-service/kernel-service.dart (left):

https://codereview.chromium.org/2665753002/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:219: if (dir.parent == dir) {
On 2017/01/31 06:18:02, Vyacheslav Egorov (Google) wrote:
> On 2017/01/31 01:53:37, rmacnak wrote:
> > This is always true. dart.io.Directory are only equal if they are identical,
> not
> > if they have the same path/inode/etc.
> 
> This code was copied from the Loader code so it has the same bug. The reason
why
> this code is written like this is because we have the following comment for
the
> parent:
> 
>   /**
>    * The directory containing [this].  If [this] is a root
>    * directory, returns [this].
>    */
> 
> But implementation does not actually follow the comment :-/

Ah, disregard this comment. Loader does not have this bug --- I changed it when
I copied it because I read the description of the .parent and thought that I am
improving it, but it turns out that loader code was working around the
documentation problem.

[rmacnak, 2017-01-31 17:47:56]

Description was changed from

==========
Reapply "Create an app snapshot of the Dart front end."

Skip training on Windows, issue #28532.
==========

to

==========
Reapply "Create an app snapshot of the Dart front end."

Skip training on Windows, issue #28532.

R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9eb216a495f8917ba1bcc55d2555d8203a76c09f
==========

[rmacnak, 2017-01-31 17:47:59]

Committed patchset #3 (id:40001) manually as
9eb216a495f8917ba1bcc55d2555d8203a76c09f (presubmit successful).