Reapply "Create an app snapshot of the Dart front end."

runtime/vm/kernel_isolate.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/kernel_isolate.h"
 
 #include "vm/compiler.h"
 #include "include/dart_native_api.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
@@ skipping 56 matching lines @@
       KernelIsolate::FinishedInitializing();
       return;
     }
 
     Dart_IsolateFlags api_flags;
     Isolate::FlagsInitialize(&api_flags);
 
     isolate = reinterpret_cast<Isolate*>(create_callback(
         KernelIsolate::kName, NULL, NULL, NULL, &api_flags, NULL, &error));
     if (isolate == NULL) {
-      if (FLAG_trace_kernel) {
-        OS::PrintErr(DART_KERNEL_ISOLATE_NAME ": Isolate creation error: %s\n",
-                     error);
-      }
+      OS::PrintErr(DART_KERNEL_ISOLATE_NAME ": Isolate creation error: %s\n",
+                   error);
       KernelIsolate::SetKernelIsolate(NULL);
       KernelIsolate::FinishedInitializing();
       return;
     }
 
     bool init_success = false;
     {
       ASSERT(Isolate::Current() == NULL);
       StartIsolateScope start_scope(isolate);
       init_success = RunMain(isolate);
@@ skipping 53 matching lines @@
 
   bool RunMain(Isolate* I) {
     Thread* T = Thread::Current();
     ASSERT(I == T->isolate());
     StackZone zone(T);
     HANDLESCOPE(T);
     // Invoke main which will return the port to which load requests are sent.
     const Library& root_library =
         Library::Handle(Z, I->object_store()->root_library());
     if (root_library.IsNull()) {
-      if (FLAG_trace_kernel) {
-        OS::Print(DART_KERNEL_ISOLATE_NAME
-                  ": Embedder did not install a script.");
-      }
+      OS::Print(DART_KERNEL_ISOLATE_NAME
+                ": Embedder did not install a script.");
       // Kernel isolate is not supported by embedder.
       return false;
     }
     ASSERT(!root_library.IsNull());
     const String& entry_name = String::Handle(Z, String::New("main"));
     ASSERT(!entry_name.IsNull());
     const Function& entry = Function::Handle(
         Z, root_library.LookupFunctionAllowPrivate(entry_name));
     if (entry.IsNull()) {
       // Kernel isolate is not supported by embedder.
-      if (FLAG_trace_kernel) {
-        OS::Print(DART_KERNEL_ISOLATE_NAME
-                  ": Embedder did not provide a main function.");
-      }
+      OS::Print(DART_KERNEL_ISOLATE_NAME
+                ": Embedder did not provide a main function.");
       return false;
     }
     ASSERT(!entry.IsNull());
     const Object& result = Object::Handle(
         Z, DartEntry::InvokeFunction(entry, Object::empty_array()));
     ASSERT(!result.IsNull());
     if (result.IsError()) {
       // Kernel isolate did not initialize properly.
-      if (FLAG_trace_kernel) {
-        const Error& error = Error::Cast(result);
-        OS::Print(DART_KERNEL_ISOLATE_NAME
-                  ": Calling main resulted in an error: %s",
-                  error.ToErrorCString());
-      }
+      const Error& error = Error::Cast(result);
+      OS::Print(DART_KERNEL_ISOLATE_NAME
+                ": Calling main resulted in an error: %s",
+                error.ToErrorCString());
       return false;
     }
     ASSERT(result.IsReceivePort());
     const ReceivePort& rp = ReceivePort::Cast(result);
     KernelIsolate::SetLoadPort(rp.Id());
     return true;
   }
 };
 
 
@@ skipping 245 matching lines @@
   }
 
   KernelCompilationRequest request;
   return request.SendAndWaitForResponse(kernel_port, script_uri);
 }
 
 
 #endif  // DART_PRECOMPILED_RUNTIME
 
 }  // namespace dart