Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_fetcher.h

Issue 2665743002: [Remote suggestions] Clean up variation params in the fetcher. (Closed)
Patch Set: Add a comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_fetcher.h
diff --git a/components/ntp_snippets/remote/remote_suggestions_fetcher.h b/components/ntp_snippets/remote/remote_suggestions_fetcher.h
index 84fc50b2fc376e5b918320e64c7255f77f0a3c63..90ebbacea0b04de8f57c251d3899e7790a468171 100644
--- a/components/ntp_snippets/remote/remote_suggestions_fetcher.h
+++ b/components/ntp_snippets/remote/remote_suggestions_fetcher.h
@@ -95,18 +95,12 @@ class RemoteSuggestionsFetcher : public OAuth2TokenService::Consumer,
void FetchSnippets(const RequestParams& params,
SnippetsAvailableCallback callback);
- std::string PersonalizationModeString() const;
-
// Debug string representing the status/result of the last fetch attempt.
const std::string& last_status() const { return last_status_; }
// Returns the last JSON fetched from the server.
const std::string& last_json() const { return last_fetch_json_; }
- // Returns the personalization setting of the fetcher as used in tests.
- // TODO(fhorschig): Reconsider these tests and remove this getter.
- Personalization personalization() const { return personalization_; }
-
// Returns the URL endpoint used by the fetcher.
const GURL& fetch_url() const { return fetch_url_; }
@@ -168,9 +162,6 @@ class RemoteSuggestionsFetcher : public OAuth2TokenService::Consumer,
bool DemandQuotaForRequest(bool interactive_request);
- // Does the fetcher use authentication to get personalized results?
- bool NeedsAuthentication() const;
-
// Authentication for signed-in users.
SigninManagerBase* signin_manager_;
OAuth2TokenService* token_service_;
@@ -201,9 +192,6 @@ class RemoteSuggestionsFetcher : public OAuth2TokenService::Consumer,
// API key to use for non-authenticated requests.
const std::string api_key_;
- // The variant of the fetching to use, loaded from variation parameters.
- Personalization personalization_;
-
// Allow for an injectable tick clock for testing.
std::unique_ptr<base::TickClock> tick_clock_;
« no previous file with comments | « components/ntp_snippets/remote/json_request_unittest.cc ('k') | components/ntp_snippets/remote/remote_suggestions_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698