[Remote suggestions] Clean up variation params in the fetcher.

components/ntp_snippets/remote/remote_suggestions_fetcher.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTIONS_FETCHER_H_
 #define COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTIONS_FETCHER_H_
 
 #include <memory>
 #include <queue>
 #include <string>
@@ skipping 77 matching lines @@
   ~RemoteSuggestionsFetcher() override;
 
   // Initiates a fetch from the server. When done (successfully or not), calls
   // the callback.
   //
   // If an ongoing fetch exists, both fetches won't influence each other (i.e.
   // every callback will be called exactly once).
   void FetchSnippets(const RequestParams& params,
                      SnippetsAvailableCallback callback);
 
-  std::string PersonalizationModeString() const;
-
   // Debug string representing the status/result of the last fetch attempt.
   const std::string& last_status() const { return last_status_; }
 
   // Returns the last JSON fetched from the server.
   const std::string& last_json() const { return last_fetch_json_; }
 
-  // Returns the personalization setting of the fetcher as used in tests.
-  // TODO(fhorschig): Reconsider these tests and remove this getter.
-  Personalization personalization() const { return personalization_; }
-
   // Returns the URL endpoint used by the fetcher.
   const GURL& fetch_url() const { return fetch_url_; }
 
   // Overrides internal clock for testing purposes.
   void SetTickClockForTesting(std::unique_ptr<base::TickClock> tick_clock) {
     tick_clock_ = std::move(tick_clock);
   }
 
  private:
   FRIEND_TEST_ALL_PREFIXES(ChromeReaderSnippetsFetcherTest,
@@ skipping 41 matching lines @@
   void FetchFinished(OptionalFetchedCategories categories,
                      SnippetsAvailableCallback callback,
                      internal::FetchResult status_code,
                      const std::string& error_details);
 
   bool JsonToSnippets(const base::Value& parsed,
                       FetchedCategoriesVector* categories);
 
   bool DemandQuotaForRequest(bool interactive_request);
 
-  // Does the fetcher use authentication to get personalized results?
-  bool NeedsAuthentication() const;
-
   // Authentication for signed-in users.
   SigninManagerBase* signin_manager_;
   OAuth2TokenService* token_service_;
   std::unique_ptr<OAuth2TokenService::Request> oauth_request_;
   bool waiting_for_refresh_token_ = false;
 
   // When a token request gets canceled, we want to retry once.
   bool oauth_token_retried_ = false;
 
   // Holds the URL request context.
@@ skipping 10 matching lines @@
   const ParseJSONCallback parse_json_callback_;
 
   // API endpoint for fetching suggestions.
   const GURL fetch_url_;
   // Which API to use
   const internal::FetchAPI fetch_api_;
 
   // API key to use for non-authenticated requests.
   const std::string api_key_;
 
-  // The variant of the fetching to use, loaded from variation parameters.
-  Personalization personalization_;
-
   // Allow for an injectable tick clock for testing.
   std::unique_ptr<base::TickClock> tick_clock_;
 
   // Classifier that tells us how active the user is. Not owned.
   const UserClassifier* user_classifier_;
 
   // Request throttlers for limiting requests for different classes of users.
   RequestThrottler request_throttler_rare_ntp_user_;
   RequestThrottler request_throttler_active_ntp_user_;
   RequestThrottler request_throttler_active_suggestions_consumer_;
 
   // Info on the last finished fetch.
   std::string last_status_;
   std::string last_fetch_json_;
 
   base::WeakPtrFactory<RemoteSuggestionsFetcher> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RemoteSuggestionsFetcher);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTIONS_FETCHER_H_