Reset username for the Active Directory login

Reset username for the Active Directory login

BUG=677517
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2665683002
Cr-Commit-Position: refs/heads/master@{#447750}
Committed: https://chromium.googlesource.com/chromium/src/+/f8fbc2f83697f63ebb397b5a4212e1635dc4f33a

[Roman Sorokin (ftl), 2017-01-30 13:23:21]

Description was changed from

==========
Reset username for the Active Directory login

BUG=677517
TEST=manual
==========

to

==========
Reset username for the Active Directory login

BUG=677517
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Roman Sorokin (ftl), 2017-01-30 13:23:26]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 13:23:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-30 13:23:50]

rsorokin@chromium.org changed reviewers:
+ achuith@chromium.org

[Roman Sorokin (ftl), 2017-01-30 13:23:51]

Hey Achuith, could you PTAL?

[commit-bot: I haz the power, 2017-01-30 14:50:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 14:50:15]

Dry run: This issue passed the CQ dry run.

[achuithb, 2017-01-30 23:53:34]

https://codereview.chromium.org/2665683002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (left):

https://codereview.chromium.org/2665683002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:1094: if ('email'
in params)
How does this change help?

[Roman Sorokin (ftl), 2017-01-31 08:13:50]

On 2017/01/30 23:53:34, achuithb wrote:
>
https://codereview.chromium.org/2665683002/diff/1/chrome/browser/resources/ch...
> File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (left):
> 
>
https://codereview.chromium.org/2665683002/diff/1/chrome/browser/resources/ch...
> chrome/browser/resources/chromeos/login/screen_gaia_signin.js:1094: if
('email'
> in params)
> How does this change help?

When there is no email it makes input field empty. There could be leftovers from
the previous login.

[achuithb, 2017-02-02 00:40:15]

lgtm

[Roman Sorokin (ftl), 2017-02-02 10:58:29]

The CQ bit was checked by rsorokin@chromium.org

[commit-bot: I haz the power, 2017-02-02 10:58:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 12:56:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486033109462800, "parent_rev":
"38085832fa9b018027dd0aa2068afef12e37777b", "commit_rev":
"f8fbc2f83697f63ebb397b5a4212e1635dc4f33a"}

[commit-bot: I haz the power, 2017-02-02 12:56:31]

Description was changed from

==========
Reset username for the Active Directory login

BUG=677517
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Reset username for the Active Directory login

BUG=677517
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2665683002
Cr-Commit-Position: refs/heads/master@{#447750}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8fbc2f83697f63ebb397b5a4212...
==========

[commit-bot: I haz the power, 2017-02-02 12:56:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f8fbc2f83697f63ebb397b5a4212...