Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2665653004: ValueSerializer: Share string encoding code with String and RegExp objects. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ValueSerializer: Share string encoding code with String and RegExp objects. This avoids the need to pull in the UTF-8 encoding code from the public API, and allows it to take advantage of any supported way that i::String can be encoded (one- or two-byte). Backward compatibility is maintained, but this is the behavior beginning with this version. BUG=chromium:686159 Review-Url: https://codereview.chromium.org/2665653004 Cr-Commit-Position: refs/heads/master@{#42872} Committed: https://chromium.googlesource.com/v8/v8/+/591cc0b4ccdb6934d76ea163569b5194faef4dcf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -23 lines) Patch
M src/value-serializer.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/value-serializer.cc View 6 chunks +15 lines, -23 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jbroman
This removes the need to convert to v8::Local<v8::String> to get UTF-8 text.
3 years, 10 months ago (2017-01-31 17:53:07 UTC) #10
Jakob Kummerow
lgtm
3 years, 10 months ago (2017-02-01 20:29:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665653004/1
3 years, 10 months ago (2017-02-01 21:57:09 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 22:27:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/591cc0b4ccdb6934d76ea163569b5194fae...

Powered by Google App Engine
This is Rietveld 408576698