Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2665603003: Add detection of Shoutcast responses and accept them as valid HTTP/0.9 (Closed)

Created:
3 years, 10 months ago by mmenke
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Add detection of Shoutcast responses and accept them as valid HTTP/0.9 responses over HTTP ports other than port 80, unlike other HTTP/0.9 responses. BUG=669800 Review-Url: https://codereview.chromium.org/2648253004 Cr-Commit-Position: refs/heads/master@{#446867} (cherry picked from commit d78f5290a5585d318081007097b9b2ba3b1cf311) TBR=mmenke@chormium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2665603003 Cr-Commit-Position: refs/branch-heads/2987@{#176} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9c2e8faa7a7eadb232fb4f5c2a1eaccbae88c129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -31 lines) Patch
M net/http/http_stream_parser.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M net/http/http_stream_parser_unittest.cc View 3 chunks +99 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665603003/1
3 years, 10 months ago (2017-01-30 19:56:25 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-01-30 19:56:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665603003/1
3 years, 10 months ago (2017-01-30 19:57:23 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 19:59:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c2e8faa7a7eadb232fb4f5c2a1e...

Powered by Google App Engine
This is Rietveld 408576698