Change setIsLink to conform with other nonproperty setters.

Change setIsLink to conform with other nonproperty setters.

In ComputedStyle, there are a few fields that are not CSS properties.
They are mostly boolean fields, with getters and setters. The setters
take no arguments and simply sets the boolean field to true. One
exception is the isLink field, whose setter takes an argument and assigns
the field to the argument (like a normal setter). However, we only use
the setter as 'setIsLink(true)'. This patch changes the setIsLink setter
to conform to the other nonproperty setters.

This is prework for generating nonproperty fields in ComputedStyle. This
patch allows us to generate the setter for isLink like the other
nonproperty fields.

BUG=628043
Review-Url: https://codereview.chromium.org/2665603002
Cr-Commit-Position: refs/heads/master@{#447173}
Committed: https://chromium.googlesource.com/chromium/src/+/7f4313ab6f2a84dffb7394c6311afa8e1e0a5667

[shend, 2017-01-29 23:22:06]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-01-29 23:22:07]

Hey Naina, PTAL :)

[nainar, 2017-01-29 23:26:26]

lgtm

[shend, 2017-01-29 23:34:45]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 23:34:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-01-29 23:35:34]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-01-29 23:35:35]

Hey Sasha PTAL.

[commit-bot: I haz the power, 2017-01-30 01:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 01:18:57]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-01-30 23:51:44]

LGTM!! This is the greatest CL description I've ever seen. I had 2 questions but
they were both answered from your great explanation.

Your CLs have all been incredible quality. Keep it up! :) (Y)

[shend, 2017-01-31 00:29:07]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-01-31 00:29:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 03:07:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485822547705110, "parent_rev":
"db5a002c687e3090619035927813f02c2635b0d4", "commit_rev":
"7f4313ab6f2a84dffb7394c6311afa8e1e0a5667"}

[commit-bot: I haz the power, 2017-01-31 03:07:50]

Description was changed from

==========
Change setIsLink to conform with other nonproperty setters.

In ComputedStyle, there are a few fields that are not CSS properties.
They are mostly boolean fields, with getters and setters. The setters
take no arguments and simply sets the boolean field to true. One
exception is the isLink field, whose setter takes an argument and assigns
the field to the argument (like a normal setter). However, we only use
the setter as 'setIsLink(true)'. This patch changes the setIsLink setter
to conform to the other nonproperty setters.

This is prework for generating nonproperty fields in ComputedStyle. This
patch allows us to generate the setter for isLink like the other
nonproperty fields.

BUG=628043
==========

to

==========
Change setIsLink to conform with other nonproperty setters.

In ComputedStyle, there are a few fields that are not CSS properties.
They are mostly boolean fields, with getters and setters. The setters
take no arguments and simply sets the boolean field to true. One
exception is the isLink field, whose setter takes an argument and assigns
the field to the argument (like a normal setter). However, we only use
the setter as 'setIsLink(true)'. This patch changes the setIsLink setter
to conform to the other nonproperty setters.

This is prework for generating nonproperty fields in ComputedStyle. This
patch allows us to generate the setter for isLink like the other
nonproperty fields.

BUG=628043

Review-Url: https://codereview.chromium.org/2665603002
Cr-Commit-Position: refs/heads/master@{#447173}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f4313ab6f2a84dffb7394c6311a...
==========

[commit-bot: I haz the power, 2017-01-31 03:07:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7f4313ab6f2a84dffb7394c6311a...