Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2665503003: W3C test importer: Clean up temp repo after abort. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

W3C test importer: Clean up temp repo after abort. After running wpt-import when there are exportable-but-not-exported commits, I noticed that the wpt repo isn't automatically cleaned up, but it should be. BUG=666540 Review-Url: https://codereview.chromium.org/2665503003 Cr-Commit-Position: refs/heads/master@{#446935} Committed: https://chromium.googlesource.com/chromium/src/+/7288124e6c7c52f9c55d684d657f1fd2df0ea1e3

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
qyearsley
3 years, 10 months ago (2017-01-28 18:41:58 UTC) #3
jeffcarp
lgtm
3 years, 10 months ago (2017-01-29 00:37:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665503003/40001
3 years, 10 months ago (2017-01-29 02:56:20 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-29 04:20:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7288124e6c7c52f9c55d684d657f...

Powered by Google App Engine
This is Rietveld 408576698