Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2665463002: Use previous target path when resuming a download after crash (Closed)

Created:
3 years, 10 months ago by qinmin
Modified:
3 years, 10 months ago
Reviewers:
asanka
CC:
chromium-reviews, asanka
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Use previous target path when resuming a download after crash When resuming a download after browser crash, Chrome will regenerate the target path. This could reintroduce name conflict if user has resolved a conflict before the crash. This CL reuses the previous target path Chrome has already generated for the download. BUG=678835 TBR=asanka@chromium.org Review-Url: https://codereview.chromium.org/2618743006 Cr-Commit-Position: refs/heads/master@{#446218} (cherry picked from commit 41231a3e20197bf9499332f02c69a426186f5fbe) Review-Url: https://codereview.chromium.org/2665463002 . Cr-Commit-Position: refs/branch-heads/2987@{#154} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7e8d5bafdb010fa97aaecb9e0ebf61f462129366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M chrome/browser/download/download_target_determiner.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
3 years, 10 months ago (2017-01-27 21:36:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e8d5bafdb010fa97aaecb9e0ebf61f462129366 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698