Enable service_unittests on several bot configurations

Enable service_unittests on several bot configurations

BUG=685847
Review-Url: https://codereview.chromium.org/2665453002
Cr-Commit-Position: refs/heads/master@{#446890}
Committed: https://chromium.googlesource.com/chromium/src/+/8cdd37a13cbdd5d3906cb675ee02124d866a330d

[Ken Rockot(use gerrit already), 2017-01-27 20:54:07]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 20:54:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-27 20:56:06]

rockot@chromium.org changed reviewers:
+ dpranke@chromium.org

[commit-bot: I haz the power, 2017-01-27 21:01:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 21:01:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ken Rockot(use gerrit already), 2017-01-27 21:06:10]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 21:06:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 23:34:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 23:34:39]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2017-01-28 00:13:13]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 00:14:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 00:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 00:19:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2017-01-28 00:21:28]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 00:21:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-01-28 00:50:54]

dpranke@chromium.org changed reviewers:
+ bpastene@chromium.org, jbudorick@chromium.org

[Dirk Pranke, 2017-01-28 00:50:55]

lgtm, apart from possibly whether or not we have the capacity to run this on
android. How fast is this test?

https://codereview.chromium.org/2665453002/diff/60001/testing/buildbot/chromi...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/2665453002/diff/60001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:1013: "test": "service_unittests"
Are you sure we have the capacity to add this test on android? You should
probably check w/ jbudorick@ or bpastene@.

[Ken Rockot(use gerrit already), 2017-01-28 00:53:16]

Not sure at all, but this is currently a very lightweight test suite. This
code is used in production so it would be a good idea to have unit test
coverage on Android.

On Fri, Jan 27, 2017 at 4:50 PM, <dpranke@chromium.org> wrote:

> lgtm, apart from possibly whether or not we have the capacity to run this
> on
> android. How fast is this test?
>
>
> https://codereview.chromium.org/2665453002/diff/60001/
> testing/buildbot/chromium.linux.json
> File testing/buildbot/chromium.linux.json (right):
>
> https://codereview.chromium.org/2665453002/diff/60001/
> testing/buildbot/chromium.linux.json#newcode1013
> testing/buildbot/chromium.linux.json:1013: "test": "service_unittests"
> Are you sure we have the capacity to add this test on android? You
> should probably check w/ jbudorick@ or bpastene@.
>
> https://codereview.chromium.org/2665453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2017-01-28 00:54:31]

I am also planning to merge several other tests into this suite (
http://crbug.com/686329) which will increase the workload a bit.

How do we gauge whether a test is going to push us over capacity?

On Fri, Jan 27, 2017 at 4:53 PM, Ken Rockot <rockot@chromium.org> wrote:

> Not sure at all, but this is currently a very lightweight test suite. This
> code is used in production so it would be a good idea to have unit test
> coverage on Android.
>
> On Fri, Jan 27, 2017 at 4:50 PM, <dpranke@chromium.org> wrote:
>
>> lgtm, apart from possibly whether or not we have the capacity to run this
>> on
>> android. How fast is this test?
>>
>>
>> https://codereview.chromium.org/2665453002/diff/60001/testin
>> g/buildbot/chromium.linux.json
>> File testing/buildbot/chromium.linux.json (right):
>>
>> https://codereview.chromium.org/2665453002/diff/60001/testin
>> g/buildbot/chromium.linux.json#newcode1013
>> testing/buildbot/chromium.linux.json:1013: "test": "service_unittests"
>> Are you sure we have the capacity to add this test on android? You
>> should probably check w/ jbudorick@ or bpastene@.
>>
>> https://codereview.chromium.org/2665453002/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2017-01-28 00:57:02]

On 2017/01/28 00:54:31, Ken Rockot wrote:
> I am also planning to merge several other tests into this suite (
> http://crbug.com/686329) which will increase the workload a bit.
> 
> How do we gauge whether a test is going to push us over capacity?

Good question. We don't have a great answer for this at the moment.

If the test is fast (<< 1 minute), it probably doesn't matter.

Otherwise, normally we'd want you to either run it on an FYI bot so we can gauge
load
a little better, or we'd do some capacity checks in infra/test-land. Capacity
stuff isn't
public, but I could point you to internal graphs that are hard to use :).

[Ken Rockot(use gerrit already), 2017-01-28 00:59:15]

Well I can at least assure you that for now these tests complete in a total
~1-2 seconds on my local Nexus 6, so I suppose it's probably safe.

On Fri, Jan 27, 2017 at 4:57 PM, <dpranke@chromium.org> wrote:

> On 2017/01/28 00:54:31, Ken Rockot wrote:
> > I am also planning to merge several other tests into this suite (
> > http://crbug.com/686329) which will increase the workload a bit.
> >
> > How do we gauge whether a test is going to push us over capacity?
>
> Good question. We don't have a great answer for this at the moment.
>
> If the test is fast (<< 1 minute), it probably doesn't matter.
>
> Otherwise, normally we'd want you to either run it on an FYI bot so we can
> gauge
> load
> a little better, or we'd do some capacity checks in infra/test-land.
> Capacity
> stuff isn't
> public, but I could point you to internal graphs that are hard to use :).
>
>
> https://codereview.chromium.org/2665453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jbudorick, 2017-01-28 01:03:20]

On 2017/01/28 00:57:02, Dirk Pranke wrote:
> On 2017/01/28 00:54:31, Ken Rockot wrote:
> > I am also planning to merge several other tests into this suite (
> > http://crbug.com/686329) which will increase the workload a bit.
> > 
> > How do we gauge whether a test is going to push us over capacity?
> 
> Good question. We don't have a great answer for this at the moment.
> 
> If the test is fast (<< 1 minute), it probably doesn't matter.
> 
> Otherwise, normally we'd want you to either run it on an FYI bot so we can
gauge
> load
> a little better, or we'd do some capacity checks in infra/test-land. Capacity
> stuff isn't
> public, but I could point you to internal graphs that are hard to use :).

This suite should definitely be added to the N5X bot
(https://codesearch.chromium.org/chromium/src/testing/buildbot/chromium.androi...),
but the N5 bot is very close to capacity at peak at the moment. That'll be
alleviated this quarter, but I'm somewhat wary of adding more suites before that
happens.

Bear in mind that, even if these tests run in <5 seconds, they still incur
per-task overhead in cleanup that, iirc, currently takes ~1 minute.

[Ken Rockot(use gerrit already), 2017-01-28 01:05:22]

Should I not add it to any Android bots until we can add it to N5X? Or is
this alright to land as-is?

On Fri, Jan 27, 2017 at 5:03 PM, <jbudorick@chromium.org> wrote:

> On 2017/01/28 00:57:02, Dirk Pranke wrote:
> > On 2017/01/28 00:54:31, Ken Rockot wrote:
> > > I am also planning to merge several other tests into this suite (
> > > http://crbug.com/686329) which will increase the workload a bit.
> > >
> > > How do we gauge whether a test is going to push us over capacity?
> >
> > Good question. We don't have a great answer for this at the moment.
> >
> > If the test is fast (<< 1 minute), it probably doesn't matter.
> >
> > Otherwise, normally we'd want you to either run it on an FYI bot so we
> can
> gauge
> > load
> > a little better, or we'd do some capacity checks in infra/test-land.
> Capacity
> > stuff isn't
> > public, but I could point you to internal graphs that are hard to use :).
>
> This suite should definitely be added to the N5X bot
> (https://codesearch.chromium.org/chromium/src/testing/
> buildbot/chromium.android.json?rcl=0&l=7),
> but the N5 bot is very close to capacity at peak at the moment. That'll be
> alleviated this quarter, but I'm somewhat wary of adding more suites
> before that
> happens.
>
> Bear in mind that, even if these tests run in <5 seconds, they still incur
> per-task overhead in cleanup that, iirc, currently takes ~1 minute.
>
> https://codereview.chromium.org/2665453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jbudorick, 2017-01-28 01:07:41]

On 2017/01/28 01:05:22, Ken Rockot wrote:
> Should I not add it to any Android bots until we can add it to N5X? Or is
> this alright to land as-is?

You should add it to the N5X now, and I think this is ok to land with just that.
File a bug to add it to the N5 when we have capacity and assign it to me.

> 
> On Fri, Jan 27, 2017 at 5:03 PM, <mailto:jbudorick@chromium.org> wrote:
> 
> > On 2017/01/28 00:57:02, Dirk Pranke wrote:
> > > On 2017/01/28 00:54:31, Ken Rockot wrote:
> > > > I am also planning to merge several other tests into this suite (
> > > > http://crbug.com/686329) which will increase the workload a bit.
> > > >
> > > > How do we gauge whether a test is going to push us over capacity?
> > >
> > > Good question. We don't have a great answer for this at the moment.
> > >
> > > If the test is fast (<< 1 minute), it probably doesn't matter.
> > >
> > > Otherwise, normally we'd want you to either run it on an FYI bot so we
> > can
> > gauge
> > > load
> > > a little better, or we'd do some capacity checks in infra/test-land.
> > Capacity
> > > stuff isn't
> > > public, but I could point you to internal graphs that are hard to use :).
> >
> > This suite should definitely be added to the N5X bot
> > (https://codesearch.chromium.org/chromium/src/testing/
> > buildbot/chromium.android.json?rcl=0&l=7),
> > but the N5 bot is very close to capacity at peak at the moment. That'll be
> > alleviated this quarter, but I'm somewhat wary of adding more suites
> > before that
> > happens.
> >
> > Bear in mind that, even if these tests run in <5 seconds, they still incur
> > per-task overhead in cleanup that, iirc, currently takes ~1 minute.
> >
> > https://codereview.chromium.org/2665453002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2017-01-28 01:08:51]

Ahh, thanks. Misread, didn't see "N5". :)

On Fri, Jan 27, 2017 at 5:07 PM, <jbudorick@chromium.org> wrote:

> On 2017/01/28 01:05:22, Ken Rockot wrote:
> > Should I not add it to any Android bots until we can add it to N5X? Or is
> > this alright to land as-is?
>
> You should add it to the N5X now, and I think this is ok to land with just
> that.
> File a bug to add it to the N5 when we have capacity and assign it to me.
>
>
> >
> > On Fri, Jan 27, 2017 at 5:03 PM, <mailto:jbudorick@chromium.org> wrote:
> >
> > > On 2017/01/28 00:57:02, Dirk Pranke wrote:
> > > > On 2017/01/28 00:54:31, Ken Rockot wrote:
> > > > > I am also planning to merge several other tests into this suite (
> > > > > http://crbug.com/686329) which will increase the workload a bit.
> > > > >
> > > > > How do we gauge whether a test is going to push us over capacity?
> > > >
> > > > Good question. We don't have a great answer for this at the moment.
> > > >
> > > > If the test is fast (<< 1 minute), it probably doesn't matter.
> > > >
> > > > Otherwise, normally we'd want you to either run it on an FYI bot so
> we
> > > can
> > > gauge
> > > > load
> > > > a little better, or we'd do some capacity checks in infra/test-land.
> > > Capacity
> > > > stuff isn't
> > > > public, but I could point you to internal graphs that are hard to
> use :).
> > >
> > > This suite should definitely be added to the N5X bot
> > > (https://codesearch.chromium.org/chromium/src/testing/
> > > buildbot/chromium.android.json?rcl=0&l=7),
> > > but the N5 bot is very close to capacity at peak at the moment.
> That'll be
> > > alleviated this quarter, but I'm somewhat wary of adding more suites
> > > before that
> > > happens.
> > >
> > > Bear in mind that, even if these tests run in <5 seconds, they still
> incur
> > > per-task overhead in cleanup that, iirc, currently takes ~1 minute.
> > >
> > > https://codereview.chromium.org/2665453002/
> > >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
>
>
>
> https://codereview.chromium.org/2665453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2017-01-28 01:11:26]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 01:11:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-28 01:20:01]

On 2017/01/28 at 01:08:51, Ken Rockot wrote:
> Ahh, thanks. Misread, didn't see "N5". :)
> 
> On Fri, Jan 27, 2017 at 5:07 PM, <jbudorick@chromium.org> wrote:
> 
> > On 2017/01/28 01:05:22, Ken Rockot wrote:
> > > Should I not add it to any Android bots until we can add it to N5X? Or is
> > > this alright to land as-is?
> >
> > You should add it to the N5X now, and I think this is ok to land with just
> > that.
> > File a bug to add it to the N5 when we have capacity and assign it to me.

Done and done (http://crbug.com/686349)

> >
> >
> > >
> > > On Fri, Jan 27, 2017 at 5:03 PM, <mailto:jbudorick@chromium.org> wrote:
> > >
> > > > On 2017/01/28 00:57:02, Dirk Pranke wrote:
> > > > > On 2017/01/28 00:54:31, Ken Rockot wrote:
> > > > > > I am also planning to merge several other tests into this suite (
> > > > > > http://crbug.com/686329) which will increase the workload a bit.
> > > > > >
> > > > > > How do we gauge whether a test is going to push us over capacity?
> > > > >
> > > > > Good question. We don't have a great answer for this at the moment.
> > > > >
> > > > > If the test is fast (<< 1 minute), it probably doesn't matter.
> > > > >
> > > > > Otherwise, normally we'd want you to either run it on an FYI bot so
> > we
> > > > can
> > > > gauge
> > > > > load
> > > > > a little better, or we'd do some capacity checks in infra/test-land.
> > > > Capacity
> > > > > stuff isn't
> > > > > public, but I could point you to internal graphs that are hard to
> > use :).
> > > >
> > > > This suite should definitely be added to the N5X bot
> > > > (https://codesearch.chromium.org/chromium/src/testing/
> > > > buildbot/chromium.android.json?rcl=0&l=7),
> > > > but the N5 bot is very close to capacity at peak at the moment.
> > That'll be
> > > > alleviated this quarter, but I'm somewhat wary of adding more suites
> > > > before that
> > > > happens.
> > > >
> > > > Bear in mind that, even if these tests run in <5 seconds, they still
> > incur
> > > > per-task overhead in cleanup that, iirc, currently takes ~1 minute.
> > > >
> > > > https://codereview.chromium.org/2665453002/
> > > >
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "Chromium-reviews" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an
> > email
> > > to mailto:chromium-reviews+unsubscribe@chromium.org.
> >
> >
> >
> > https://codereview.chromium.org/2665453002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to chromium-reviews+unsubscribe@chromium.org.
>

[jbudorick, 2017-01-28 01:23:15]

https://codereview.chromium.org/2665453002/diff/80001/testing/buildbot/chromi...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/2665453002/diff/80001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:984: "override_isolate_target":
"service_unittests",
Remove this one for now.

[Ken Rockot(use gerrit already), 2017-01-28 01:24:33]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2017-01-28 01:24:41]

On 2017/01/28 at 01:23:15, jbudorick wrote:
>
https://codereview.chromium.org/2665453002/diff/80001/testing/buildbot/chromi...
> File testing/buildbot/chromium.linux.json (right):
> 
>
https://codereview.chromium.org/2665453002/diff/80001/testing/buildbot/chromi...
> testing/buildbot/chromium.linux.json:984: "override_isolate_target":
"service_unittests",
> Remove this one for now.

done

[commit-bot: I haz the power, 2017-01-28 01:24:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-01-28 01:42:43]

lgtm w/ nits

your timing vis a vis
https://chromium.googlesource.com/chromium/src/+/7bea51146249f12bb9b6af2a7113...
is unfortunate.

https://codereview.chromium.org/2665453002/diff/100001/testing/buildbot/chrom...
File testing/buildbot/chromium.android.json (right):

https://codereview.chromium.org/2665453002/diff/100001/testing/buildbot/chrom...
testing/buildbot/chromium.android.json:939: "revision":
"git_revision:25755a2c316937ee44a6432163dc5e2f9c85cf58"
nit: this should be updated to dec8cc6fd715753846d0aca1693dc63844ea55d6

https://codereview.chromium.org/2665453002/diff/100001/testing/buildbot/chrom...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/2665453002/diff/100001/testing/buildbot/chrom...
testing/buildbot/chromium.linux.json:2203: "revision":
"git_revision:25755a2c316937ee44a6432163dc5e2f9c85cf58"
nit: this should be updated to dec8cc6fd715753846d0aca1693dc63844ea55d6

[Ken Rockot(use gerrit already), 2017-01-28 01:46:11]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2017-01-28 01:46:14]

Thanks! Updated the revisions.

On Fri, Jan 27, 2017 at 5:42 PM, <jbudorick@chromium.org> wrote:

> lgtm w/ nits
>
> your timing vis a vis
> https://chromium.googlesource.com/chromium/src/+/
> 7bea51146249f12bb9b6af2a7113701033b2a334
> is unfortunate.
>
>
> https://codereview.chromium.org/2665453002/diff/100001/
> testing/buildbot/chromium.android.json
> File testing/buildbot/chromium.android.json (right):
>
> https://codereview.chromium.org/2665453002/diff/100001/
> testing/buildbot/chromium.android.json#newcode939
> testing/buildbot/chromium.android.json:939: "revision":
> "git_revision:25755a2c316937ee44a6432163dc5e2f9c85cf58"
> nit: this should be updated to dec8cc6fd715753846d0aca1693dc63844ea55d6
>
> https://codereview.chromium.org/2665453002/diff/100001/
> testing/buildbot/chromium.linux.json
> File testing/buildbot/chromium.linux.json (right):
>
> https://codereview.chromium.org/2665453002/diff/100001/
> testing/buildbot/chromium.linux.json#newcode2203
> testing/buildbot/chromium.linux.json:2203: "revision":
> "git_revision:25755a2c316937ee44a6432163dc5e2f9c85cf58"
> nit: this should be updated to dec8cc6fd715753846d0aca1693dc63844ea55d6
>
> https://codereview.chromium.org/2665453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-01-28 01:46:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-28 01:46:35]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-01-28 01:46:36]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-01-28 01:46:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2665453002/#ps120001
(title: ".")

[commit-bot: I haz the power, 2017-01-28 01:46:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 02:53:35]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1485567996925710,
"parent_rev": "560640b659f688387d4c239e00f2dc941607e9f0", "commit_rev":
"8cdd37a13cbdd5d3906cb675ee02124d866a330d"}

[commit-bot: I haz the power, 2017-01-28 02:54:08]

Description was changed from

==========
Enable service_unittests on several bot configurations

BUG=685847
==========

to

==========
Enable service_unittests on several bot configurations

BUG=685847

Review-Url: https://codereview.chromium.org/2665453002
Cr-Commit-Position: refs/heads/master@{#446890}
Committed:
https://chromium.googlesource.com/chromium/src/+/8cdd37a13cbdd5d3906cb675ee02...
==========

[commit-bot: I haz the power, 2017-01-28 02:54:10]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/8cdd37a13cbdd5d3906cb675ee02...