Enfore "clang-format" for all of src/ios/.

Enfore "clang-format" for all of src/ios/.

As we're adding more and more code outside of stc/ios/{web,chrome},
add a presubmit check enforcing "clang-format" for all of src/ios/
instead of limiting it to select sub-directories of src/ios/.

BUG=None

Review-Url: https://codereview.chromium.org/2665383002
Cr-Commit-Position: refs/heads/master@{#447541}
Committed: https://chromium.googlesource.com/chromium/src/+/b742db2fa3101ae54b7de497497b0643cf723ad4

[sdefresne, 2017-02-01 16:11:36]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 16:11:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-02-01 16:13:53]

sdefresne@chromium.org changed reviewers:
+ marq@chromium.org, rohitrao@chromium.org

[sdefresne, 2017-02-01 16:13:54]

marq/rohitrao: can you both take a look?

With ios/clean, ios/shared, ios/showcase recently added, I think it is best to
just move the presubmit directly to ios. If you feel that we should have more
control on which directories we want to enforce formatting and which we don't I
can be more specific, but I think it will risk bit rotting.

WDYT?

[marq (ping after 24h), 2017-02-01 16:28:58]

LGTM

[rohitrao (ping after 24h), 2017-02-01 16:29:02]

I am fine with this.

[rohitrao (ping after 24h), 2017-02-01 16:29:19]

lgtm

[sdefresne, 2017-02-01 16:56:21]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-02-01 16:56:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-02-01 16:58:03]

On 2017/02/01 16:29:19, rohitrao wrote:
> lgtm

Follow-up question: should I fix the formatting of all code outside of ios/web &
ios/chrome that may not be formatted with clang-format (and update the
.git-blame-ignore-revs)?

[commit-bot: I haz the power, 2017-02-01 17:03:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485968181654970,
"parent_rev": "b29ec7143c6fbc8ea4271c7f5e3428dae0c4eba8", "commit_rev":
"b742db2fa3101ae54b7de497497b0643cf723ad4"}

[commit-bot: I haz the power, 2017-02-01 17:03:49]

Description was changed from

==========
Enfore "clang-format" for all of src/ios/.

As we're adding more and more code outside of stc/ios/{web,chrome},
add a presubmit check enforcing "clang-format" for all of src/ios/
instead of limiting it to select sub-directories of src/ios/.

BUG=None
==========

to

==========
Enfore "clang-format" for all of src/ios/.

As we're adding more and more code outside of stc/ios/{web,chrome},
add a presubmit check enforcing "clang-format" for all of src/ios/
instead of limiting it to select sub-directories of src/ios/.

BUG=None

Review-Url: https://codereview.chromium.org/2665383002
Cr-Commit-Position: refs/heads/master@{#447541}
Committed:
https://chromium.googlesource.com/chromium/src/+/b742db2fa3101ae54b7de497497b...
==========

[commit-bot: I haz the power, 2017-02-01 17:03:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b742db2fa3101ae54b7de497497b...