Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2665353003: [ObjC ARC] Converts ios/public/provider/chrome/browser/user_feedback:test_support to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/public/provider/chrome/browser/user_feedback:test_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2665353003 Cr-Commit-Position: refs/heads/master@{#463234} Committed: https://chromium.googlesource.com/chromium/src/+/b32bd33d9cc8fe5878699aec420309bdabaaec7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/public/provider/chrome/browser/user_feedback/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/user_feedback/test_user_feedback_provider.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
stkhapugin
ptal
3 years, 10 months ago (2017-02-02 10:12:14 UTC) #6
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-02 11:44:21 UTC) #7
stkhapugin
Thank you!
3 years, 8 months ago (2017-04-07 14:53:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665353003/1
3 years, 8 months ago (2017-04-07 14:54:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/189390)
3 years, 8 months ago (2017-04-07 15:58:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665353003/1
3 years, 8 months ago (2017-04-10 11:33:51 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 12:45:35 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b32bd33d9cc8fe5878699aec4203...

Powered by Google App Engine
This is Rietveld 408576698