Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2665313003: ValueSerializer: Check for zero length before casting to FixedDoubleArray. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
Reviewers:
binji
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ValueSerializer: Check for zero length before casting to FixedDoubleArray. Even though the elements kind is FAST_DOUBLE_ELEMENTS, if length is zero the isolate's empty_fixed_array is used. It's illegal to cast this to FixedDoubleArray, so we avoid the cast. BUG=chromium:686479 Review-Url: https://codereview.chromium.org/2665313003 Cr-Commit-Position: refs/heads/master@{#42867} Committed: https://chromium.googlesource.com/v8/v8/+/c3856de3714e62943d4bed100346158c227318a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/value-serializer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
3 years, 10 months ago (2017-02-01 06:07:58 UTC) #6
binji
lgtm
3 years, 10 months ago (2017-02-01 20:13:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665313003/1
3 years, 10 months ago (2017-02-01 20:22:44 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 20:26:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c3856de3714e62943d4bed100346158c227...

Powered by Google App Engine
This is Rietveld 408576698