Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2665303003: Convert print_dialog_cloud::SignInObserver to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert print_dialog_cloud::SignInObserver to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2665303003 Cr-Commit-Position: refs/heads/master@{#447649} Committed: https://chromium.googlesource.com/chromium/src/+/a3d5801d55db75ed92b135170b561f2eab7761f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/printing/print_dialog_cloud.cc View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 10 months ago (2017-02-01 21:55:34 UTC) #7
dpapad
lgtm
3 years, 10 months ago (2017-02-01 23:52:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665303003/1
3 years, 10 months ago (2017-02-01 23:55:29 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 00:01:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3d5801d55db75ed92b135170b56...

Powered by Google App Engine
This is Rietveld 408576698