Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: net/http2/hpack/decoder/hpack_whole_entry_buffer.cc

Issue 2665283003: Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider. (Closed)
Patch Set: address bnc comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http2/hpack/decoder/hpack_whole_entry_buffer.cc
diff --git a/net/http2/hpack/decoder/hpack_whole_entry_buffer.cc b/net/http2/hpack/decoder/hpack_whole_entry_buffer.cc
index 8bb212f40aaea1a96eb983ac0cfa4ec3e0f0d897..d239aca8ecd728c690827c0b5f5ed965bc163b50 100644
--- a/net/http2/hpack/decoder/hpack_whole_entry_buffer.cc
+++ b/net/http2/hpack/decoder/hpack_whole_entry_buffer.cc
@@ -32,6 +32,10 @@ void HpackWholeEntryBuffer::BufferStringsIfUnbuffered() {
value_.BufferStringIfUnbuffered();
}
+size_t HpackWholeEntryBuffer::EstimateMemoryUsage() const {
+ return name_.BufferedLength() + value_.BufferedLength();
DmitrySkiba 2017/02/02 18:16:27 Hmm, can we add EMU to HpackDecoderStringBuffer? B
xunjieli 2017/02/03 22:25:09 Done.
+}
+
void HpackWholeEntryBuffer::OnIndexedHeader(size_t index) {
DVLOG(2) << "HpackWholeEntryBuffer::OnIndexedHeader: index=" << index;
listener_->OnIndexedHeader(index);

Powered by Google App Engine
This is Rietveld 408576698