net/http2/hpack/decoder/http2_hpack_decoder.h - Issue 2665283003: Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http2/hpack/decoder/http2_hpack_decoder.h

Issue 2665283003: Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider. (Closed)

Patch Set: address bnc comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http2/hpack/decoder/http2_hpack_decoder.h

diff --git a/net/http2/hpack/decoder/http2_hpack_decoder.h b/net/http2/hpack/decoder/http2_hpack_decoder.h

index fff1320b4af63a7bcfb1ab666cd0666754928b7e..d053c3acb52919f52e23786843a647c3c17e5ad3 100644

--- a/net/http2/hpack/decoder/http2_hpack_decoder.h

+++ b/net/http2/hpack/decoder/http2_hpack_decoder.h

@@ -95,6 +95,9 @@ class NET_EXPORT_PRIVATE Http2HpackDecoder {

// Was an error detected?

bool error_detected();

+ // Returns the estimate of dynamically allocated memory in bytes.

+ size_t EstimateMemoryUsage() const;

private:

friend class test::Http2HpackDecoderPeer;