Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2665213003: Encode URIs stored in unlinked summaries to make them Uri.parse() safe. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Encode URIs stored in unlinked summaries to make them Uri.parse() safe. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/023648ec5ea09df897e6dd68f56a8061cdf625b6

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -7 lines) Patch
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 2 chunks +4 lines, -2 lines 1 comment Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 1 chunk +14 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 3 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 10 months ago (2017-02-01 17:23:49 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2665213003/diff/1/pkg/analyzer/lib/src/summary/public_namespace_computer.dart File pkg/analyzer/lib/src/summary/public_namespace_computer.dart (right): https://codereview.chromium.org/2665213003/diff/1/pkg/analyzer/lib/src/summary/public_namespace_computer.dart#newcode150 pkg/analyzer/lib/src/summary/public_namespace_computer.dart:150: String uriStr = Uri.encodeFull(node.uri.stringValue ?? ''); Consider a ...
3 years, 10 months ago (2017-02-01 17:28:24 UTC) #2
Paul Berry
lgtm
3 years, 10 months ago (2017-02-01 17:32:56 UTC) #3
scheglov
3 years, 10 months ago (2017-02-01 17:36:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
023648ec5ea09df897e6dd68f56a8061cdf625b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698