pkg/analyzer/lib/src/summary/summarize_ast.dart - Issue 2665213003: Encode URIs stored in unlinked summaries to make them Uri.parse() safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/summary/summarize_ast.dart

Issue 2665213003: Encode URIs stored in unlinked summaries to make them Uri.parse() safe. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/summary/summarize_ast.dart

diff --git a/pkg/analyzer/lib/src/summary/summarize_ast.dart b/pkg/analyzer/lib/src/summary/summarize_ast.dart

index 240fa8000cae17a4614eb07cb90d362c4ba6ccb7..6017647cc5f3cee858d2845ad736a63a3b3fc367 100644

--- a/pkg/analyzer/lib/src/summary/summarize_ast.dart

+++ b/pkg/analyzer/lib/src/summary/summarize_ast.dart

@@ -1306,7 +1306,7 @@ class _SummarizeAstVisitor extends RecursiveAstVisitor {

b.prefixOffset = node.prefix.offset;

}

b.isDeferred = node.deferredKeyword != null;

- b.uri = node.uri.stringValue;

+ b.uri = Uri.encodeFull(node.uri.stringValue ?? '');

b.uriOffset = node.uri.offset;

b.uriEnd = node.uri.end;

unlinkedImports.add(b);