Gtk3: Fix gn_all compile

Gtk3: Fix gn_all compile

This CL fixes the remaining compile errors when building all targets
with use_gtk3=true.

BUG=132847
R=sergeyu@chromium.org
CC=erg@chromium.org,wez@chromium.org

Review-Url: https://codereview.chromium.org/2665203005
Cr-Commit-Position: refs/heads/master@{#448372}
Committed: https://chromium.googlesource.com/chromium/src/+/206251b17bbac92e0d8c4cae1d9a01f8da780f6b

[Tom (Use chromium acct), 2017-02-01 00:02:42]

sergeyu@ PTAL

This cl is untested as I don't know how to run the resulting
chrome-remote-desktop-host executable

https://codereview.chromium.org/2665203005/diff/1/remoting/host/disconnect_wi...
File remoting/host/disconnect_window_linux.cc (right):

https://codereview.chromium.org/2665203005/diff/1/remoting/host/disconnect_wi...
remoting/host/disconnect_window_linux.cc:207: #if GTK_MAJOR_VERSION == 2
We can just let gtk draw the window background, right?

[Sergey Ulanov, 2017-02-01 20:12:57]

I'm verifying this fix, but there seems to be another unrelated crash. I'll
update this CL when I get this resolved.

[Sergey Ulanov, 2017-02-02 00:42:49]

I think we want to keep the current design for the disconnect window, see my
comment.
To try this UI: 
 1. Build remoting_all
 2. Run remoting/tools/remoting/tools/register_local_nm_hosts.sh
 3. Install CRD:
https://chrome.google.com/webstore/detail/chrome-remote-desktop/gbchcmhmhahfd...
 4. Open CRD and click "Share" in the Remote Access section
 5. Open CRD click "Access" and copy the code from "Share"

Disconnect window will pop up when connection is established

https://codereview.chromium.org/2665203005/diff/1/remoting/host/disconnect_wi...
File remoting/host/disconnect_window_linux.cc (right):

https://codereview.chromium.org/2665203005/diff/1/remoting/host/disconnect_wi...
remoting/host/disconnect_window_linux.cc:207: #if GTK_MAJOR_VERSION == 2
On 2017/02/01 00:02:42, Tom Anderson wrote:
> We can just let gtk draw the window background, right?

I don't think we want to omit this code. This code draws not only the
background, but also rounded corners, green border and gripper on the left. E.g.
here is the screenshot with GTK2:
https://drive.google.com/file/d/0B692SWJoRn0_cGszS09qakl0eEU/view?usp=sharing

[Tom (Use chromium acct), 2017-02-02 19:32:14]

On 2017/02/02 00:42:49, Sergey Ulanov wrote:
> I think we want to keep the current design for the disconnect window, see my
> comment.
> To try this UI: 
>  1. Build remoting_all
>  2. Run remoting/tools/remoting/tools/register_local_nm_hosts.sh
>  3. Install CRD:
>
https://chrome.google.com/webstore/detail/chrome-remote-desktop/gbchcmhmhahfd...
>  4. Open CRD and click "Share" in the Remote Access section
>  5. Open CRD click "Access" and copy the code from "Share"
> 
> Disconnect window will pop up when connection is established
> 
>
https://codereview.chromium.org/2665203005/diff/1/remoting/host/disconnect_wi...
> File remoting/host/disconnect_window_linux.cc (right):
> 
>
https://codereview.chromium.org/2665203005/diff/1/remoting/host/disconnect_wi...
> remoting/host/disconnect_window_linux.cc:207: #if GTK_MAJOR_VERSION == 2
> On 2017/02/01 00:02:42, Tom Anderson wrote:
> > We can just let gtk draw the window background, right?
> 
> I don't think we want to omit this code. This code draws not only the
> background, but also rounded corners, green border and gripper on the left.
E.g.
> here is the screenshot with GTK2:
> https://drive.google.com/file/d/0B692SWJoRn0_cGszS09qakl0eEU/view?usp=sharing

Thanks, I was able to develop using your instructions.
The latest PS provides a GTK3 port of the disconnect window drawing code, ptal

[Tom (Use chromium acct), 2017-02-03 18:16:12]

ping

[Sergey Ulanov, 2017-02-06 17:40:41]

LGTM. Thank you! It's great to have this code ported to GTK3!

https://codereview.chromium.org/2665203005/diff/40001/remoting/host/disconnec...
File remoting/host/disconnect_window_linux.cc (right):

https://codereview.chromium.org/2665203005/diff/40001/remoting/host/disconnec...
remoting/host/disconnect_window_linux.cc:281: #if GTK_MAJOR_VERSION == 2
Maybe add a comment that gdk_window_set_back_pixmap() is not supported in GDK3,
and background drawing is handled in OnDraw().

https://codereview.chromium.org/2665203005/diff/40001/remoting/host/disconnec...
remoting/host/disconnect_window_linux.cc:317: #endif
  // GTK_MAJOR_VERSION == 2

[Tom (Use chromium acct), 2017-02-06 20:00:06]

https://codereview.chromium.org/2665203005/diff/40001/remoting/host/disconnec...
File remoting/host/disconnect_window_linux.cc (right):

https://codereview.chromium.org/2665203005/diff/40001/remoting/host/disconnec...
remoting/host/disconnect_window_linux.cc:281: #if GTK_MAJOR_VERSION == 2
On 2017/02/06 17:40:41, Sergey Ulanov wrote:
> Maybe add a comment that gdk_window_set_back_pixmap() is not supported in
GDK3,
> and background drawing is handled in OnDraw().

Done.

https://codereview.chromium.org/2665203005/diff/40001/remoting/host/disconnec...
remoting/host/disconnect_window_linux.cc:317: #endif
On 2017/02/06 17:40:41, Sergey Ulanov wrote:
>   // GTK_MAJOR_VERSION == 2

Done.

[Tom (Use chromium acct), 2017-02-06 20:00:09]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-02-06 20:00:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2665203005/#ps60001
(title: "Address sergeyu@'s comments")

[commit-bot: I haz the power, 2017-02-06 20:00:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 20:24:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486411209840660,
"parent_rev": "17e392b12a3b8a59fc3ca9265d1d89cda2a5509d", "commit_rev":
"206251b17bbac92e0d8c4cae1d9a01f8da780f6b"}

[commit-bot: I haz the power, 2017-02-06 20:25:13]

Description was changed from

==========
Gtk3: Fix gn_all compile

This CL fixes the remaining compile errors when building all targets
with use_gtk3=true.

BUG=132847
R=sergeyu@chromium.org
CC=erg@chromium.org,wez@chromium.org
==========

to

==========
Gtk3: Fix gn_all compile

This CL fixes the remaining compile errors when building all targets
with use_gtk3=true.

BUG=132847
R=sergeyu@chromium.org
CC=erg@chromium.org,wez@chromium.org

Review-Url: https://codereview.chromium.org/2665203005
Cr-Commit-Position: refs/heads/master@{#448372}
Committed:
https://chromium.googlesource.com/chromium/src/+/206251b17bbac92e0d8c4cae1d9a...
==========

[commit-bot: I haz the power, 2017-02-06 20:25:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/206251b17bbac92e0d8c4cae1d9a...