Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2665123002: [turbofan] Don't eliminate unused CheckFloat64Hole. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
mvstanton, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't eliminate unused CheckFloat64Hole. We cannot eliminate unused CheckFloat64Hole nodes, since loading from a holey array can have side-effects, i.e. triggering getters in the prototype chain. R=mvstanton@chromium.org BUG=chromium:686737 Review-Url: https://codereview.chromium.org/2665123002 Cr-Commit-Position: refs/heads/master@{#42806} Committed: https://chromium.googlesource.com/v8/v8/+/b8df95499338c86cf29bb8502a488a5ebf41c415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-686737.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Benedikt Meurer
3 years, 10 months ago (2017-01-31 07:17:01 UTC) #1
Jarin
lgtm
3 years, 10 months ago (2017-01-31 08:11:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665123002/1
3 years, 10 months ago (2017-01-31 08:28:59 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 08:31:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b8df95499338c86cf29bb8502a488a5ebf4...

Powered by Google App Engine
This is Rietveld 408576698