Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2665103002: [Media Router] Remove GetRouteIds() from PresentationServiceDelegateImpl. (Closed)

Created:
3 years, 10 months ago by imcheng
Modified:
3 years, 10 months ago
Reviewers:
mark a. foltz, zhaobin
CC:
chromium-reviews, feature-media-reviews_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Remove GetRouteIds() from PresentationServiceDelegateImpl. It is not used and should be removed. BUG=686978 Review-Url: https://codereview.chromium.org/2665103002 Cr-Commit-Position: refs/heads/master@{#447257} Committed: https://chromium.googlesource.com/chromium/src/+/8cfa67519ff268fa65527b999872e0365caefefe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 4 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
imcheng
PTAL
3 years, 10 months ago (2017-01-31 01:58:59 UTC) #4
zhaobin
lgtm
3 years, 10 months ago (2017-01-31 02:00:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665103002/1
3 years, 10 months ago (2017-01-31 03:54:11 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-01-31 03:54:15 UTC) #11
imcheng
+mfoltz
3 years, 10 months ago (2017-01-31 04:44:18 UTC) #13
mark a. foltz
lgtm
3 years, 10 months ago (2017-01-31 06:20:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665103002/1
3 years, 10 months ago (2017-01-31 17:26:30 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 17:31:12 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8cfa67519ff268fa65527b999872...

Powered by Google App Engine
This is Rietveld 408576698