Allow ripple hover/press effects to be more easily sized by subclasses.

Allow ripple hover/press effects to be more easily sized by subclasses.

This will be useful in the harmony work, where we want icon buttons to have a
ripple size that matches the button size, rather than using the fixed 24 px
size.

This also converts some consts to constexprs -- I needed to move one constant to
the header for my default argument values, and having it constexpr and the
things above it const looked weird.

BUG=686962
TEST=none

Review-Url: https://codereview.chromium.org/2665073002
Cr-Commit-Position: refs/heads/master@{#447178}
Committed: https://chromium.googlesource.com/chromium/src/+/233a48eb42ca4b36a788c7d366a438ff4066015b

[Peter Kasting, 2017-01-31 01:31:13]

pkasting@chromium.org changed reviewers:
+ bruthig@chromium.org

[Peter Kasting, 2017-01-31 01:31:21]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 01:31:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2017-01-31 01:43:19]

lgtm

https://codereview.chromium.org/2665073002/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_host_view.h (right):

https://codereview.chromium.org/2665073002/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_host_view.h:61: static constexpr int kInkDropSize =
24;
nit: Can you rename this to |kDefaultInkDropSize|?

[commit-bot: I haz the power, 2017-01-31 01:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 01:48:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Kasting, 2017-01-31 02:13:51]

https://codereview.chromium.org/2665073002/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_host_view.h (right):

https://codereview.chromium.org/2665073002/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_host_view.h:61: static constexpr int kInkDropSize =
24;
On 2017/01/31 01:43:19, bruthig wrote:
> nit: Can you rename this to |kDefaultInkDropSize|?

Good idea.  Done.

[Peter Kasting, 2017-01-31 02:13:55]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2017-01-31 02:13:55]

The patchset sent to the CQ was uploaded after l-g-t-m from bruthig@chromium.org
Link to the patchset: https://codereview.chromium.org/2665073002/#ps20001
(title: "Review comment, compile fix")

[commit-bot: I haz the power, 2017-01-31 02:14:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 03:37:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485828835368380,
"parent_rev": "9aaa1259f7f310e3fde9ec887248542e41a2db6e", "commit_rev":
"233a48eb42ca4b36a788c7d366a438ff4066015b"}

[commit-bot: I haz the power, 2017-01-31 03:37:34]

Description was changed from

==========
Allow ripple hover/press effects to be more easily sized by subclasses.

This will be useful in the harmony work, where we want icon buttons to have a
ripple size that matches the button size, rather than using the fixed 24 px
size.

This also converts some consts to constexprs -- I needed to move one constant to
the header for my default argument values, and having it constexpr and the
things above it const looked weird.

BUG=686962
TEST=none
==========

to

==========
Allow ripple hover/press effects to be more easily sized by subclasses.

This will be useful in the harmony work, where we want icon buttons to have a
ripple size that matches the button size, rather than using the fixed 24 px
size.

This also converts some consts to constexprs -- I needed to move one constant to
the header for my default argument values, and having it constexpr and the
things above it const looked weird.

BUG=686962
TEST=none

Review-Url: https://codereview.chromium.org/2665073002
Cr-Commit-Position: refs/heads/master@{#447178}
Committed:
https://chromium.googlesource.com/chromium/src/+/233a48eb42ca4b36a788c7d366a4...
==========

[commit-bot: I haz the power, 2017-01-31 03:37:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/233a48eb42ca4b36a788c7d366a4...