Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 2665053006: s390: add IsTrap check on 32-bit operation as well (Closed)

Created:
3 years, 10 months ago by john.yan
Modified:
3 years, 10 months ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: add IsTrap check on 32-bit operation as well R=bjaideep@ca.ibm.com, joransiu@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2665053006 Cr-Commit-Position: refs/heads/master@{#42897} Committed: https://chromium.googlesource.com/v8/v8/+/0516a5bb62bb59211ccae928ec9dc8f47621bb4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
john.yan
ptal
3 years, 10 months ago (2017-02-02 17:36:39 UTC) #1
JoranSiu
On 2017/02/02 17:36:39, john.yan wrote: > ptal lgtm
3 years, 10 months ago (2017-02-02 17:38:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665053006/1
3 years, 10 months ago (2017-02-02 17:53:43 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 18:17:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0516a5bb62bb59211ccae928ec9dc8f4762...

Powered by Google App Engine
This is Rietveld 408576698