Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2665053002: Add tests for detecting lost associated interfaces. (Closed)

Created:
3 years, 10 months ago by Sam McNally
Modified:
3 years, 10 months ago
Reviewers:
Tom Sepez, yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for detecting lost associated interfaces. BUG=686955 Review-Url: https://codereview.chromium.org/2665053002 Cr-Commit-Position: refs/heads/master@{#448139} Committed: https://chromium.googlesource.com/chromium/src/+/5c8a6c605dc41954b355cd30eb926b8c2143a148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M ipc/ipc_channel_mojo_unittest.cc View 2 chunks +49 lines, -0 lines 0 comments Download
M ipc/ipc_test.mojom View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/associated_interface_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_associated_interfaces.mojom View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yzshen1
LGTM
3 years, 10 months ago (2017-02-02 00:36:08 UTC) #5
Sam McNally
+tsepez for //ipc
3 years, 10 months ago (2017-02-02 19:34:47 UTC) #9
Tom Sepez
lgtm
3 years, 10 months ago (2017-02-03 20:01:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665053002/1
3 years, 10 months ago (2017-02-04 01:05:39 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 01:34:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5c8a6c605dc41954b355cd30eb92...

Powered by Google App Engine
This is Rietveld 408576698