Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 2664973002: Let HTML UI manage menu mode. (Closed)

Created:
3 years, 10 months ago by cjgrant
Modified:
3 years, 10 months ago
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let HTML UI fully manage menu mode. - Have native pass app button presses up to the UI. - The UI decides whether or not to be in menu mode. - The UI may call back down to native to pause content, if desired. BUG=644565 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2664973002 Cr-Commit-Position: refs/heads/master@{#448017} Committed: https://chromium.googlesource.com/chromium/src/+/cb6d69f2601372a0fbc8760fbb62c7f6e0cc3cd8

Patch Set 1 #

Total comments: 17

Patch Set 2 : Address review comments. #

Total comments: 6

Patch Set 3 : Rebase to ToT. #

Patch Set 4 : Rebase again to resolve ToT conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -50 lines) Patch
M chrome/browser/android/vr_shell/ui_interface.h View 1 2 3 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_interface.cc View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 1 2 3 5 chunks +28 lines, -20 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.js View 1 2 3 2 chunks +28 lines, -15 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui_api.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (10 generated)
cjgrant
There are a couple points for discussion in this CL. Please see comments... https://codereview.chromium.org/2664973002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File ...
3 years, 10 months ago (2017-01-30 21:55:57 UTC) #3
asimjour1
https://codereview.chromium.org/2664973002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2664973002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc#newcode367 chrome/browser/android/vr_shell/vr_shell.cc:367: case SET_CONTENT_PAUSED: { nit: please remove the brace https://codereview.chromium.org/2664973002/diff/1/chrome/browser/resources/vr_shell/vr_shell_ui.js ...
3 years, 10 months ago (2017-01-31 15:34:00 UTC) #4
bshe
https://codereview.chromium.org/2664973002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2664973002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc#newcode175 chrome/browser/android/vr_shell/vr_shell.cc:175: if (content_paused_ != paused) { nit: prefer early return ...
3 years, 10 months ago (2017-01-31 17:03:32 UTC) #5
cjgrant
https://codereview.chromium.org/2664973002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2664973002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc#newcode175 chrome/browser/android/vr_shell/vr_shell.cc:175: if (content_paused_ != paused) { On 2017/01/31 17:03:31, bshe ...
3 years, 10 months ago (2017-02-02 16:58:59 UTC) #6
mthiesse
https://codereview.chromium.org/2664973002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2664973002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc#newcode177 chrome/browser/android/vr_shell/vr_shell.cc:177: if (delegate_provider_->device_provider()) { On 2017/01/30 21:55:56, cjgrant wrote: > ...
3 years, 10 months ago (2017-02-02 17:01:33 UTC) #7
cjgrant
https://codereview.chromium.org/2664973002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2664973002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc#newcode183 chrome/browser/android/vr_shell/vr_shell.cc:183: delegate_provider_->device_provider()->OnDisplayBlur(); On 2017/02/02 17:01:33, mthiesse wrote: > Note: on ...
3 years, 10 months ago (2017-02-02 17:05:56 UTC) #8
bshe
On 2017/02/02 17:05:56, cjgrant wrote: > https://codereview.chromium.org/2664973002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc > File chrome/browser/android/vr_shell/vr_shell.cc (right): > > https://codereview.chromium.org/2664973002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc#newcode183 > ...
3 years, 10 months ago (2017-02-02 17:11:57 UTC) #9
mthiesse
https://codereview.chromium.org/2664973002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (left): https://codereview.chromium.org/2664973002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc#oldcode288 chrome/browser/android/vr_shell/vr_shell.cc:288: #if defined(ENABLE_VR_SHELL) I know you didn't write this, but ...
3 years, 10 months ago (2017-02-02 18:01:11 UTC) #10
cjgrant1
https://codereview.chromium.org/2664973002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (left): https://codereview.chromium.org/2664973002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc#oldcode288 chrome/browser/android/vr_shell/vr_shell.cc:288: #if defined(ENABLE_VR_SHELL) On 2017/02/02 18:01:10, mthiesse wrote: > I ...
3 years, 10 months ago (2017-02-02 19:25:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664973002/40001
3 years, 10 months ago (2017-02-02 19:26:00 UTC) #15
commit-bot: I haz the power
Failed to apply patch for chrome/browser/android/vr_shell/ui_interface.h: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-02 21:10:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664973002/60001
3 years, 10 months ago (2017-02-03 16:05:25 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 17:38:36 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cb6d69f2601372a0fbc8760fbb62...

Powered by Google App Engine
This is Rietveld 408576698