Do not block in SimpleThread::Start().

base/win/wait_chain_unittest.cc

Index: base/win/wait_chain_unittest.cc
diff --git a/base/win/wait_chain_unittest.cc b/base/win/wait_chain_unittest.cc
index ba04872206d561234436fc6a344d339bce8727db..5dc6f56f1a41eda5d7d572cb3a8c92eb0c647051 100644
--- a/base/win/wait_chain_unittest.cc
+++ b/base/win/wait_chain_unittest.cc
@@ -109,7 +109,7 @@ class DeadlockThread : public SimpleThread {
 
   // Terminates the thread.
   bool Terminate() {
-    ScopedHandle thread_handle(::OpenThread(THREAD_TERMINATE, FALSE, tid()));
+    ScopedHandle thread_handle(::OpenThread(THREAD_TERMINATE, FALSE, GetTid()));

[gab, 2017/02/06 20:29:11]

Need to allow wait on these or is it allowed by default in tests?

[fdoray, 2017/02/06 20:46:48]

Allowed by default. Disallowed on UI and IO threads + a few other cases
https://cs.chromium.org/search/?q=disallowwaiting&type=cs

     return ::TerminateThread(thread_handle.Get(), 0);
   }
 
@@ -259,7 +259,7 @@ TEST(WaitChainTest, Deadlock) {
 
   WaitChainNodeVector wait_chain;
   bool is_deadlock;
-  ASSERT_TRUE(GetThreadWaitChain(waiting_thread_2->tid(), &wait_chain,
+  ASSERT_TRUE(GetThreadWaitChain(waiting_thread_2->GetTid(), &wait_chain,
                                  &is_deadlock, nullptr, nullptr));
 
   EXPECT_EQ(9U, wait_chain.size());
@@ -298,7 +298,7 @@ TEST(WaitChainTest, CrossProcess) {
 
   WaitChainNodeVector wait_chain;
   bool is_deadlock;
-  ASSERT_TRUE(GetThreadWaitChain(waiting_thread_3->tid(), &wait_chain,
+  ASSERT_TRUE(GetThreadWaitChain(waiting_thread_3->GetTid(), &wait_chain,
                                  &is_deadlock, nullptr, nullptr));
 
   EXPECT_EQ(7U, wait_chain.size());