Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2664893002: Enable nacl_loader service in mustash (Closed)

Created:
3 years, 10 months ago by Peng
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, jam, sadrul, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable nacl_loader service in mustash The nacl plugin is not working in mustash because we don't include nacl related manifest files in mustash. PS. Netflix uses plugin widevine for cdm. BUG=684003 Review-Url: https://codereview.chromium.org/2664893002 Cr-Commit-Position: refs/heads/master@{#447204} Committed: https://chromium.googlesource.com/chromium/src/+/442ad9d283785dd39eac18186811e61c58395e3b

Patch Set 1 #

Patch Set 2 : UPDATE #

Patch Set 3 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/app/mash/BUILD.gn View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M mash/BUILD.gn View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Peng
Hi Scott, PTAL. Thanks.
3 years, 10 months ago (2017-01-30 19:28:00 UTC) #3
sky
LGTM
3 years, 10 months ago (2017-01-31 00:00:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664893002/20001
3 years, 10 months ago (2017-01-31 03:57:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/161425)
3 years, 10 months ago (2017-01-31 04:09:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664893002/40001
3 years, 10 months ago (2017-01-31 06:11:24 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 07:39:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/442ad9d283785dd39eac18186811...

Powered by Google App Engine
This is Rietveld 408576698