[turbofan] Support fast access to the current global object.

[turbofan] Support fast access to the current global object.

This is essentially a port of http://crrev.com/2403003002 to TurboFan,
adding support for fast access to JSGlobalObject properties through the
current native contexts' JSGlobalProxy.

It's a slightly bigger change, since JSNativeContextSpecialization and
JSGlobalObjectSpecialization needs merging for this to work, as due to
different type feedback layout we cannot just turn a JSLoadNamed into
JSLoadGlobal operator (and same for JSStoreNamed vs. JSStoreGlobal).
This part of the change is mostly mechanical.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
R=ishell@chromium.org, jochen@chromium.org
BUG=chromium:634276, v8:5267
Review-Url: https://codereview.chromium.org/2664853002
Cr-Commit-Position: refs/heads/master@{#42805}
Committed: https://chromium.googlesource.com/v8/v8/+/a14f22818851558ec51f04f5fa3396e242f10b78

[Benedikt Meurer, 2017-01-30 18:09:53]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 18:09:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-01-30 18:11:18]

Despite being huge, this CL is mostly mechanical refactoring. I marked the two
new places, which are ports of the Crankshaft CL.

https://codereview.chromium.org/2664853002/diff/1/src/compiler/js-native-cont...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2664853002/diff/1/src/compiler/js-native-cont...
src/compiler/js-native-context-specialization.cc:536: if (receiver_maps.length()
== 1) {
This is part one of the new stuff.

https://codereview.chromium.org/2664853002/diff/1/src/compiler/js-native-cont...
src/compiler/js-native-context-specialization.cc:761: // Check if we are
accessing the current native contexts' global proxy.
And this is part two of the new stuff.

[commit-bot: I haz the power, 2017-01-30 18:17:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 18:17:07]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Benedikt Meurer, 2017-01-30 18:27:14]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 18:27:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 18:46:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 18:46:33]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/16592)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21846)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Benedikt Meurer, 2017-01-30 18:56:42]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 18:56:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 19:27:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 19:27:33]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-01-30 23:09:34]

lgtm with nits

https://codereview.chromium.org/2664853002/diff/40001/src/compiler/js-native-...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2664853002/diff/40001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:289: Reduction
JSNativeContextSpecialization::ReduceGlobalAccess(
Drive-by comment: the load and store cases are rather different than similar.
There are only about 15 common lines out of 170.

https://codereview.chromium.org/2664853002/diff/40001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:539:
handle(JSFunction::cast(receiver_map->GetConstructor()), isolate());
s/ = handle//

[Benedikt Meurer, 2017-01-31 04:54:59]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 04:55:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-01-31 04:55:10]

Thanks!

https://codereview.chromium.org/2664853002/diff/40001/src/compiler/js-native-...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2664853002/diff/40001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:289: Reduction
JSNativeContextSpecialization::ReduceGlobalAccess(
On 2017/01/30 23:09:33, Igor Sheludko wrote:
> Drive-by comment: the load and store cases are rather different than similar.
> There are only about 15 common lines out of 170.

Acknowledged.

https://codereview.chromium.org/2664853002/diff/40001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:539:
handle(JSFunction::cast(receiver_map->GetConstructor()), isolate());
On 2017/01/30 23:09:33, Igor Sheludko wrote:
> s/ = handle//

Done.

[Benedikt Meurer, 2017-01-31 04:55:16]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-01-31 04:55:18]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-01-31 04:55:18]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2664853002/#ps60001
(title: "Address comments.")

[Benedikt Meurer, 2017-01-31 04:55:23]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-01-31 04:55:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-01-31 04:55:28]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-01-31 04:56:00]

Description was changed from

==========
[turbofan] Support fast access to the current global object.

This is essentially a port of http://crrev.com/2403003002 to TurboFan,
adding support for fast access to JSGlobalObject properties through the
current native contexts' JSGlobalProxy.

It's a slightly bigger change, since JSNativeContextSpecialization and
JSGlobalObjectSpecialization needs merging for this to work, as due to
different type feedback layout we cannot just turn a JSLoadNamed into
JSLoadGlobal operator (and same for JSStoreNamed vs. JSStoreGlobal).
This part of the change is mostly mechanical.

R=ishell@chromium.org, jochen@chromium.org
BUG=chromium:634276,v8:5267
==========

to

==========
[turbofan] Support fast access to the current global object.

This is essentially a port of http://crrev.com/2403003002 to TurboFan,
adding support for fast access to JSGlobalObject properties through the
current native contexts' JSGlobalProxy.

It's a slightly bigger change, since JSNativeContextSpecialization and
JSGlobalObjectSpecialization needs merging for this to work, as due to
different type feedback layout we cannot just turn a JSLoadNamed into
JSLoadGlobal operator (and same for JSStoreNamed vs. JSStoreGlobal).
This part of the change is mostly mechanical.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
R=ishell@chromium.org, jochen@chromium.org
BUG=chromium:634276,v8:5267
==========

[Benedikt Meurer, 2017-01-31 04:56:06]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-01-31 04:56:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 06:47:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485838566282320,
"parent_rev": "daad4319c960b714c270b2c603b1f03bbc6ade14", "commit_rev":
"a14f22818851558ec51f04f5fa3396e242f10b78"}

[commit-bot: I haz the power, 2017-01-31 06:47:07]

Description was changed from

==========
[turbofan] Support fast access to the current global object.

This is essentially a port of http://crrev.com/2403003002 to TurboFan,
adding support for fast access to JSGlobalObject properties through the
current native contexts' JSGlobalProxy.

It's a slightly bigger change, since JSNativeContextSpecialization and
JSGlobalObjectSpecialization needs merging for this to work, as due to
different type feedback layout we cannot just turn a JSLoadNamed into
JSLoadGlobal operator (and same for JSStoreNamed vs. JSStoreGlobal).
This part of the change is mostly mechanical.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
R=ishell@chromium.org, jochen@chromium.org
BUG=chromium:634276,v8:5267
==========

to

==========
[turbofan] Support fast access to the current global object.

This is essentially a port of http://crrev.com/2403003002 to TurboFan,
adding support for fast access to JSGlobalObject properties through the
current native contexts' JSGlobalProxy.

It's a slightly bigger change, since JSNativeContextSpecialization and
JSGlobalObjectSpecialization needs merging for this to work, as due to
different type feedback layout we cannot just turn a JSLoadNamed into
JSLoadGlobal operator (and same for JSStoreNamed vs. JSStoreGlobal).
This part of the change is mostly mechanical.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
R=ishell@chromium.org, jochen@chromium.org
BUG=chromium:634276,v8:5267

Review-Url: https://codereview.chromium.org/2664853002
Cr-Commit-Position: refs/heads/master@{#42805}
Committed:
https://chromium.googlesource.com/v8/v8/+/a14f22818851558ec51f04f5fa3396e242f...
==========

[commit-bot: I haz the power, 2017-01-31 06:47:08]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/a14f22818851558ec51f04f5fa3396e242f...