Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: src/frames.cc

Issue 2664793002: [debugger] account for inlined functions when stepping. (Closed)
Patch Set: comment addressed Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/frames.h ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index 1840f935def69df7331f1670e9be555d79f5d6b0..f206dbdd996a69e0b01c27af8ce6f04f5bc32f5c 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -954,6 +954,16 @@ void JavaScriptFrame::GetFunctions(List<SharedFunctionInfo*>* functions) const {
functions->Add(function()->shared());
}
+void JavaScriptFrame::GetFunctions(
+ List<Handle<SharedFunctionInfo>>* functions) const {
+ DCHECK(functions->length() == 0);
+ List<SharedFunctionInfo*> raw_functions;
+ GetFunctions(&raw_functions);
+ for (const auto& raw_function : raw_functions) {
+ functions->Add(Handle<SharedFunctionInfo>(raw_function));
+ }
+}
+
void JavaScriptFrame::Summarize(List<FrameSummary>* functions,
FrameSummary::Mode mode) const {
DCHECK(functions->length() == 0);
« no previous file with comments | « src/frames.h ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698