Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1428)

Unified Diff: test/cctest/test-debug.cc

Issue 2664793002: [debugger] account for inlined functions when stepping. (Closed)
Patch Set: comment addressed Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/frames.cc ('k') | test/debugger/regress/regress-5901-1.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index 54904f9b84007d13c877ee7284f23e68584f11f3..e053a4e604d71be5c10799679970c3e85fabe7ea 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -6456,14 +6456,13 @@ TEST(BreakLocationIterator) {
Handle<i::SharedFunctionInfo> shared(function->shared());
EnableDebugger(isolate);
- CHECK(i_isolate->debug()->EnsureDebugInfo(shared, function));
+ CHECK(i_isolate->debug()->EnsureDebugInfo(shared));
Handle<i::DebugInfo> debug_info(shared->GetDebugInfo());
Handle<i::AbstractCode> abstract_code(shared->abstract_code());
{
- auto iterator = i::BreakIterator::GetIterator(debug_info, abstract_code,
- i::ALL_BREAK_LOCATIONS);
+ auto iterator = i::BreakIterator::GetIterator(debug_info, abstract_code);
CHECK(iterator->GetBreakLocation().IsDebuggerStatement());
CHECK_EQ(17, iterator->GetBreakLocation().position());
iterator->Next();
@@ -6482,18 +6481,6 @@ TEST(BreakLocationIterator) {
CHECK(iterator->Done());
}
- {
- auto iterator = i::BreakIterator::GetIterator(debug_info, abstract_code,
- i::CALLS_AND_RETURNS);
- CHECK(iterator->GetBreakLocation().IsCall());
- CHECK_EQ(32, iterator->GetBreakLocation().position());
- iterator->Next();
- CHECK(iterator->GetBreakLocation().IsReturn());
- CHECK_EQ(60, iterator->GetBreakLocation().position());
- iterator->Next();
- CHECK(iterator->Done());
- }
-
DisableDebugger(isolate);
}
« no previous file with comments | « src/frames.cc ('k') | test/debugger/regress/regress-5901-1.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698