Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2664773002: Hide warning sign for Active Directory pods (Closed)

Created:
3 years, 10 months ago by Roman Sorokin (ftl)
Modified:
3 years, 10 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide warning sign for Active Directory pods Active Directory users are forced to auth online. Pods for auth online flow has a warning sign. It's slightly confusing for users. BUG=677128 TEST=manual Review-Url: https://codereview.chromium.org/2664773002 Cr-Commit-Position: refs/heads/master@{#447209} Committed: https://chromium.googlesource.com/chromium/src/+/ec1cf8daea6307e92975c7d699994fa89f899467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_row.css View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Roman Sorokin (ftl)
Hey Achuith, could you PTAL? I just added attribute 'is-active-directory' to the UserPod. Should I ...
3 years, 10 months ago (2017-01-30 13:11:29 UTC) #2
achuithb
On 2017/01/30 13:11:29, Roman Sorokin wrote: > Hey Achuith, could you PTAL? > > I ...
3 years, 10 months ago (2017-01-30 23:54:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664773002/1
3 years, 10 months ago (2017-01-31 08:14:55 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 08:58:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec1cf8daea6307e92975c7d69999...

Powered by Google App Engine
This is Rietveld 408576698