Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2521)

Unified Diff: extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
diff --git a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc b/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
index a910b4ae62f7bca4a3bef9de553d8efbae9986df..6dbbc9b164d3d22fbfc59797c66606dae8670017 100644
--- a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
+++ b/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
@@ -334,7 +334,7 @@ void WebViewInternalCaptureVisibleRegionFunction::OnCaptureSuccess(
return;
}
- SetResult(base::MakeUnique<base::StringValue>(base64_result));
+ SetResult(base::MakeUnique<base::Value>(base64_result));
SendResponse(true);
}
@@ -703,8 +703,8 @@ ExtensionFunction::ResponseAction WebViewInternalGetZoomModeFunction::Run() {
NOTREACHED();
}
- return RespondNow(OneArgument(base::MakeUnique<base::StringValue>(
- web_view_internal::ToString(zoom_mode))));
+ return RespondNow(OneArgument(
+ base::MakeUnique<base::Value>(web_view_internal::ToString(zoom_mode))));
}
WebViewInternalFindFunction::WebViewInternalFindFunction() {

Powered by Google App Engine
This is Rietveld 408576698