Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: extensions/browser/api/declarative/declarative_api.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative/declarative_api.cc
diff --git a/extensions/browser/api/declarative/declarative_api.cc b/extensions/browser/api/declarative/declarative_api.cc
index 6fdeacc6ed4dee733efc3d9a7edf7278887c588b..84dbfffe50c3a907f8a2c9e76ed680bbb14b6a7e 100644
--- a/extensions/browser/api/declarative/declarative_api.cc
+++ b/extensions/browser/api/declarative/declarative_api.cc
@@ -41,12 +41,11 @@ void ConvertBinaryDictionaryValuesToBase64(base::DictionaryValue* dict);
// Encodes |binary| as base64 and returns a new StringValue populated with the
// encoded string.
-std::unique_ptr<base::StringValue> ConvertBinaryToBase64(
- base::BinaryValue* binary) {
+std::unique_ptr<base::Value> ConvertBinaryToBase64(base::BinaryValue* binary) {
std::string binary_data = std::string(binary->GetBuffer(), binary->GetSize());
std::string data64;
base::Base64Encode(binary_data, &data64);
- return std::unique_ptr<base::StringValue>(new base::StringValue(data64));
+ return std::unique_ptr<base::Value>(new base::Value(data64));
}
// Parses through |args| replacing any BinaryValues with base64 encoded

Powered by Google App Engine
This is Rietveld 408576698