Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5532)

Unified Diff: chrome/browser/ui/webui/snippets_internals_message_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/snippets_internals_message_handler.cc
diff --git a/chrome/browser/ui/webui/snippets_internals_message_handler.cc b/chrome/browser/ui/webui/snippets_internals_message_handler.cc
index a186159f2b7d096bbb1e3f2fccfacfb7b9ce17b1..c67289d6709eb75f90e862b346d35164333c7727 100644
--- a/chrome/browser/ui/webui/snippets_internals_message_handler.cc
+++ b/chrome/browser/ui/webui/snippets_internals_message_handler.cc
@@ -317,7 +317,7 @@ void SnippetsInternalsMessageHandler::SendAllContent() {
SendString("switch-fetch-url", fetcher->fetch_url().spec());
web_ui()->CallJavascriptFunctionUnsafe(
"chrome.SnippetsInternals.receiveJson",
- base::StringValue(fetcher->last_json()));
+ base::Value(fetcher->last_json()));
}
SendContentSuggestions();
@@ -326,8 +326,8 @@ void SnippetsInternalsMessageHandler::SendAllContent() {
void SnippetsInternalsMessageHandler::SendClassification() {
web_ui()->CallJavascriptFunctionUnsafe(
"chrome.SnippetsInternals.receiveClassification",
- base::StringValue(content_suggestions_service_->user_classifier()
- ->GetUserClassDescriptionForDebugging()),
+ base::Value(content_suggestions_service_->user_classifier()
+ ->GetUserClassDescriptionForDebugging()),
base::Value(
content_suggestions_service_->user_classifier()->GetEstimatedAvgTime(
UserClassifier::Metric::NTP_OPENED)),
@@ -346,7 +346,7 @@ void SnippetsInternalsMessageHandler::
web_ui()->CallJavascriptFunctionUnsafe(
"chrome.SnippetsInternals."
"receiveLastRemoteSuggestionsBackgroundFetchTime",
- base::StringValue(base::TimeFormatShortDateAndTime(time)));
+ base::Value(base::TimeFormatShortDateAndTime(time)));
}
void SnippetsInternalsMessageHandler::SendContentSuggestions() {
@@ -408,8 +408,8 @@ void SnippetsInternalsMessageHandler::SendBoolean(const std::string& name,
void SnippetsInternalsMessageHandler::SendString(const std::string& name,
const std::string& value) {
- base::StringValue string_name(name);
- base::StringValue string_value(value);
+ base::Value string_name(name);
+ base::Value string_value(value);
web_ui()->CallJavascriptFunctionUnsafe(
"chrome.SnippetsInternals.receiveProperty", string_name, string_value);

Powered by Google App Engine
This is Rietveld 408576698