Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3165)

Unified Diff: base/trace_event/trace_event_memory_overhead.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/trace_event_argument.cc ('k') | base/value_conversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_memory_overhead.cc
diff --git a/base/trace_event/trace_event_memory_overhead.cc b/base/trace_event/trace_event_memory_overhead.cc
index 48a0d29f4465672778559816a1fd5cfde16401e8..8d56e1d80e8d05a7d155a2a91e424ff8a7723a25 100644
--- a/base/trace_event/trace_event_memory_overhead.cc
+++ b/base/trace_event/trace_event_memory_overhead.cc
@@ -77,9 +77,9 @@ void TraceEventMemoryOverhead::AddValue(const Value& value) {
break;
case Value::Type::STRING: {
- const StringValue* string_value = nullptr;
+ const Value* string_value = nullptr;
value.GetAsString(&string_value);
- Add("StringValue", sizeof(StringValue));
+ Add("StringValue", sizeof(Value));
AddString(string_value->GetString());
} break;
« no previous file with comments | « base/trace_event/trace_event_argument.cc ('k') | base/value_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698