Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/strings/stringprintf.h" 6 #include "base/strings/stringprintf.h"
7 #include "chrome/browser/ui/browser_commands.h" 7 #include "chrome/browser/ui/browser_commands.h"
8 #include "chrome/browser/ui/tabs/tab_strip_model.h" 8 #include "chrome/browser/ui/tabs/tab_strip_model.h"
9 #include "chrome/browser/ui/webui/media_router/media_router_ui.h" 9 #include "chrome/browser/ui/webui/media_router/media_router_ui.h"
10 #include "chrome/browser/ui/webui/media_router/media_router_web_ui_test.h" 10 #include "chrome/browser/ui/webui/media_router/media_router_web_ui_test.h"
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 route.set_incognito(incognito); 450 route.set_incognito(incognito);
451 451
452 EXPECT_CALL(*mock_media_router_ui_, GetRouteProviderExtensionId()) 452 EXPECT_CALL(*mock_media_router_ui_, GetRouteProviderExtensionId())
453 .WillOnce(ReturnRef(provider_extension_id())); 453 .WillOnce(ReturnRef(provider_extension_id()));
454 handler_->OnCreateRouteResponseReceived(sink_id, &route); 454 handler_->OnCreateRouteResponseReceived(sink_id, &route);
455 EXPECT_EQ(1u, web_ui_->call_data().size()); 455 EXPECT_EQ(1u, web_ui_->call_data().size());
456 const content::TestWebUI::CallData& call_data = *web_ui_->call_data()[0]; 456 const content::TestWebUI::CallData& call_data = *web_ui_->call_data()[0];
457 EXPECT_EQ("media_router.ui.onCreateRouteResponseReceived", 457 EXPECT_EQ("media_router.ui.onCreateRouteResponseReceived",
458 call_data.function_name()); 458 call_data.function_name());
459 const base::Value* arg1 = call_data.arg1(); 459 const base::Value* arg1 = call_data.arg1();
460 const base::StringValue* sink_id_value = nullptr; 460 const base::Value* sink_id_value = nullptr;
461 ASSERT_TRUE(arg1->GetAsString(&sink_id_value)); 461 ASSERT_TRUE(arg1->GetAsString(&sink_id_value));
462 EXPECT_EQ(sink_id, sink_id_value->GetString()); 462 EXPECT_EQ(sink_id, sink_id_value->GetString());
463 463
464 const base::Value* arg2 = call_data.arg2(); 464 const base::Value* arg2 = call_data.arg2();
465 const base::DictionaryValue* route_value = nullptr; 465 const base::DictionaryValue* route_value = nullptr;
466 ASSERT_TRUE(arg2->GetAsDictionary(&route_value)); 466 ASSERT_TRUE(arg2->GetAsDictionary(&route_value));
467 std::string value; 467 std::string value;
468 EXPECT_TRUE(route_value->GetString("id", &value)); 468 EXPECT_TRUE(route_value->GetString("id", &value));
469 EXPECT_EQ(route_id, value); 469 EXPECT_EQ(route_id, value);
470 EXPECT_TRUE(route_value->GetString("sinkId", &value)); 470 EXPECT_TRUE(route_value->GetString("sinkId", &value));
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 route.set_incognito(incognito); 505 route.set_incognito(incognito);
506 506
507 EXPECT_CALL(*mock_media_router_ui_, GetRouteProviderExtensionId()).WillOnce( 507 EXPECT_CALL(*mock_media_router_ui_, GetRouteProviderExtensionId()).WillOnce(
508 ReturnRef(provider_extension_id())); 508 ReturnRef(provider_extension_id()));
509 handler_->OnCreateRouteResponseReceived(sink_id, &route); 509 handler_->OnCreateRouteResponseReceived(sink_id, &route);
510 EXPECT_EQ(1u, web_ui_->call_data().size()); 510 EXPECT_EQ(1u, web_ui_->call_data().size());
511 const content::TestWebUI::CallData& call_data = *web_ui_->call_data()[0]; 511 const content::TestWebUI::CallData& call_data = *web_ui_->call_data()[0];
512 EXPECT_EQ("media_router.ui.onCreateRouteResponseReceived", 512 EXPECT_EQ("media_router.ui.onCreateRouteResponseReceived",
513 call_data.function_name()); 513 call_data.function_name());
514 const base::Value* arg1 = call_data.arg1(); 514 const base::Value* arg1 = call_data.arg1();
515 const base::StringValue* sink_id_value = nullptr; 515 const base::Value* sink_id_value = nullptr;
516 ASSERT_TRUE(arg1->GetAsString(&sink_id_value)); 516 ASSERT_TRUE(arg1->GetAsString(&sink_id_value));
517 EXPECT_EQ(sink_id, sink_id_value->GetString()); 517 EXPECT_EQ(sink_id, sink_id_value->GetString());
518 518
519 const base::Value* arg2 = call_data.arg2(); 519 const base::Value* arg2 = call_data.arg2();
520 const base::DictionaryValue* route_value = nullptr; 520 const base::DictionaryValue* route_value = nullptr;
521 ASSERT_TRUE(arg2->GetAsDictionary(&route_value)); 521 ASSERT_TRUE(arg2->GetAsDictionary(&route_value));
522 std::string value; 522 std::string value;
523 EXPECT_TRUE(route_value->GetString("id", &value)); 523 EXPECT_TRUE(route_value->GetString("id", &value));
524 EXPECT_EQ(route_id, value); 524 EXPECT_EQ(route_id, value);
525 EXPECT_TRUE(route_value->GetString("sinkId", &value)); 525 EXPECT_TRUE(route_value->GetString("sinkId", &value));
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
629 .WillOnce(Return(false)); 629 .WillOnce(Return(false));
630 handler_->OnRequestInitialData(&args); 630 handler_->OnRequestInitialData(&args);
631 const content::TestWebUI::CallData& call_data2 = *web_ui_->call_data()[1]; 631 const content::TestWebUI::CallData& call_data2 = *web_ui_->call_data()[1];
632 ASSERT_EQ("media_router.ui.setInitialData", call_data2.function_name()); 632 ASSERT_EQ("media_router.ui.setInitialData", call_data2.function_name());
633 ASSERT_TRUE(call_data2.arg1()->GetAsDictionary(&initial_data)); 633 ASSERT_TRUE(call_data2.arg1()->GetAsDictionary(&initial_data));
634 EXPECT_TRUE(initial_data->GetBoolean("useTabMirroring", &use_tab_mirroring)); 634 EXPECT_TRUE(initial_data->GetBoolean("useTabMirroring", &use_tab_mirroring));
635 EXPECT_FALSE(use_tab_mirroring); 635 EXPECT_FALSE(use_tab_mirroring);
636 } 636 }
637 637
638 } // namespace media_router 638 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698