Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: base/json/json_writer_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/json/json_perftest.cc ('k') | base/test/values_test_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/json/json_writer.h" 5 #include "base/json/json_writer.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 29 matching lines...) Expand all
40 40
41 // Test Real values in the the range (-1, 1) must have leading zeros 41 // Test Real values in the the range (-1, 1) must have leading zeros
42 EXPECT_TRUE(JSONWriter::Write(Value(0.2), &output_js)); 42 EXPECT_TRUE(JSONWriter::Write(Value(0.2), &output_js));
43 EXPECT_EQ("0.2", output_js); 43 EXPECT_EQ("0.2", output_js);
44 44
45 // Test Real values in the the range (-1, 1) must have leading zeros 45 // Test Real values in the the range (-1, 1) must have leading zeros
46 EXPECT_TRUE(JSONWriter::Write(Value(-0.8), &output_js)); 46 EXPECT_TRUE(JSONWriter::Write(Value(-0.8), &output_js));
47 EXPECT_EQ("-0.8", output_js); 47 EXPECT_EQ("-0.8", output_js);
48 48
49 // Test String values. 49 // Test String values.
50 EXPECT_TRUE(JSONWriter::Write(StringValue("foo"), &output_js)); 50 EXPECT_TRUE(JSONWriter::Write(Value("foo"), &output_js));
51 EXPECT_EQ("\"foo\"", output_js); 51 EXPECT_EQ("\"foo\"", output_js);
52 } 52 }
53 53
54 TEST(JSONWriterTest, NestedTypes) { 54 TEST(JSONWriterTest, NestedTypes) {
55 std::string output_js; 55 std::string output_js;
56 56
57 // Writer unittests like empty list/dict nesting, 57 // Writer unittests like empty list/dict nesting,
58 // list list nesting, etc. 58 // list list nesting, etc.
59 DictionaryValue root_dict; 59 DictionaryValue root_dict;
60 std::unique_ptr<ListValue> list(new ListValue()); 60 std::unique_ptr<ListValue> list(new ListValue());
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 145
146 // Test allowing a double with no fractional part to be written as an integer. 146 // Test allowing a double with no fractional part to be written as an integer.
147 Value double_value(1e10); 147 Value double_value(1e10);
148 EXPECT_TRUE(JSONWriter::WriteWithOptions( 148 EXPECT_TRUE(JSONWriter::WriteWithOptions(
149 double_value, JSONWriter::OPTIONS_OMIT_DOUBLE_TYPE_PRESERVATION, 149 double_value, JSONWriter::OPTIONS_OMIT_DOUBLE_TYPE_PRESERVATION,
150 &output_js)); 150 &output_js));
151 EXPECT_EQ("10000000000", output_js); 151 EXPECT_EQ("10000000000", output_js);
152 } 152 }
153 153
154 } // namespace base 154 } // namespace base
OLDNEW
« no previous file with comments | « base/json/json_perftest.cc ('k') | base/test/values_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698