Watchlist: Add a password_manager ruleset, and myself to it.

Watchlist: Add a password_manager ruleset, and myself to it.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268160

[Mike West, 2014-04-30 12:43:35]

Hey Vaclav! Mind sanity-checking this WATCHLIST addition?

-mike

[vabr (Chromium), 2014-04-30 14:14:26]

LGTM!

(I considered adding myself, but then I though better of it. :) I hope you will
tell me the most interesting things your +watchlist alias sees!)

Cheers,
Vaclav

https://codereview.chromium.org/266473004/diff/1/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/266473004/diff/1/WATCHLISTS#newcode489
WATCHLISTS:489: 'filepath': 'chrome/.*/password_'\
Silly question: Are you sure this is a prefix-matching rule?
(It probably is, it just looks interesting that some of the existing rules end
with .*)

https://codereview.chromium.org/266473004/diff/1/WATCHLISTS#newcode493
WATCHLISTS:493: '|components/password_'\
You might also want to add
components/autofill/.*password.*

[Mike West, 2014-05-05 07:00:28]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-05-05 07:00:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkwst@chromium.org/266473004/20001

[Mike West, 2014-05-05 07:00:52]

https://codereview.chromium.org/266473004/diff/1/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/266473004/diff/1/WATCHLISTS#newcode489
WATCHLISTS:489: 'filepath': 'chrome/.*/password_'\
On 2014/04/30 14:14:26, vabr (Chromium) wrote:
> Silly question: Are you sure this is a prefix-matching rule?
> (It probably is, it just looks interesting that some of the existing rules end
> with .*)

According to the comment at the top of the file, yes! "The regular expression
filepath is tested against each path using re.search, so it is not usually
necessary to add .*."

https://codereview.chromium.org/266473004/diff/1/WATCHLISTS#newcode493
WATCHLISTS:493: '|components/password_'\
On 2014/04/30 14:14:26, vabr (Chromium) wrote:
> You might also want to add
> components/autofill/.*password.*

Done.

[commit-bot: I haz the power, 2014-05-05 13:12:13]

Change committed as 268160