Watchlist: Add a password_manager ruleset, and myself to it.

WATCHLISTS

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Watchlist Rules
 # Refer: http://dev.chromium.org/developers/contributing-code/watchlists
 
 # IMPORTANT: The regular expression filepath is tested against each path using
 # re.search, so it is not usually necessary to add .*.
 
@@ skipping 467 matching lines @@
         'ui/gfx/ozone/|'\
         'ui/gl/gl_.*egl.*|'\
         'ui/gl/gl_.*ozone.*'
     },
     'panels': {
       'filepath': 'chrome/browser/ui/panels'\
                   '|chrome/browser/ui/cocoa/panels'\
                   '|chrome/browser/ui/gtk/panels'\
                   '|chrome/browser/ui/views/panels'
     },
+    'password_manager': {
+      'filepath': 'chrome/.*/password_'\

[vabr (Chromium), 2014/04/30 14:14:26]

Silly question: Are you sure this is a prefix-matching rule?
(It probably is, it just looks interesting that some of the existing rules end
with .*)

[Mike West, 2014/05/05 07:00:53]

According to the comment at the top of the file, yes! "The regular expression
filepath is tested against each path using re.search, so it is not usually
necessary to add .*."

+                  '|chrome/browser/ui/passwords'\
+                  '|chrome/browser/ui/views/passwords'\
+                  '|chrome/test/data/password'\
+                  '|components/password_'\

[vabr (Chromium), 2014/04/30 14:14:26]

You might also want to add
components/autofill/.*password.*

[Mike West, 2014/05/05 07:00:53]

Done.

+    },
     'pepper_api': {
       'filepath': 'ppapi/api'\
                   '|ppapi/c',
     },
     'plugin': {
       'filepath': 'chrome/browser/plugin|chrome/plugin/|'\
         'chrome/common/plugin|webkit/glue/webplugin|webkit/glue/plugins/',
     },
     'policy_templates': {
       'filepath': 'components/policy/resources/policy_templates.json',
@@ skipping 350 matching lines @@
     'npapi_headers': ['stuartmorgan@chromium.org'],
     'ntp': ['estade+watch@chromium.org', 'dbeam+watch-ntp@chromium.org',
             'pedrosimonetti+watch@chromium.org'],
     'omnibox': ['suzhe@chromium.org'],
     'options': ['dbeam+watch-options@chromium.org'],
     'overview_mode': ['tdanderson+overview@chromium.org'],
     'ozone': ['kalyan.kondapally@intel.com', 'ozone-reviews@chromium.org',
               'rjkroege@chromium.org'],
     'panels': ['dimich@chromium.org', 'jennb@chromium.org',
                'dcheng@chromium.org', 'jianli@chromium.org'],
+    'password_manager': ['mkwst+watchlist@chromium.org'],
     'pepper_api': ['piman+watch@chromium.org',
                    'ihf+watch@chromium.org', 'yzshen+watch@chromium.org',
                    'yusukes+watch@chromium.org', 'raymes+watch@chromium.org',
                    'noelallen@chromium.org', 'binji+watch@chromium.org',
                    'nfullagar@chromium.org', 'teravest+watch@chromium.org',
                    'tzik@chromium.org'],
     'plugin': ['jam@chromium.org',
                'stuartmorgan+watch@chromium.org'],
     'policy_templates': ['joaodasilva+watch@chromium.org'],
     'predictors': ['dominich+watch@chromium.org', 'shishir+watch@chromium.org'],
@@ skipping 60 matching lines @@
     'webrtc_media': ['fischman+watch@chromium.org',
                      'wjia+watch@chromium.org',
                      'mcasas+watch@chromium.org'],
     'website_settings': ['markusheintz@chromium.org'],
     'worker': ['jam@chromium.org'],
     'x11': ['derat+watch@chromium.org',
             'sadrul@chromium.org',
             'yusukes+watch@chromium.org'],
   },
 }