Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2664683003: [turbofan] escape analysis reducer no longer confused by TypeGuards it introduced itself (Closed)

Created:
3 years, 10 months ago by Tobias Tebbi
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] escape analysis reducer no longer confused by TypeGuards it introduced itself R=bmeurer@chromium.org BUG=chromium:682570 Review-Url: https://codereview.chromium.org/2664683003 Cr-Commit-Position: refs/heads/master@{#42769} Committed: https://chromium.googlesource.com/v8/v8/+/8b6fa9d519fb4af611d91cc2c896532147ea0bda

Patch Set 1 #

Patch Set 2 : added testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M src/compiler/escape-analysis-reducer.cc View 6 chunks +15 lines, -6 lines 0 comments Download
A test/mjsunit/compiler/escape-analysis-12.js View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tobias Tebbi
3 years, 10 months ago (2017-01-30 10:50:07 UTC) #1
Benedikt Meurer
LGTM.
3 years, 10 months ago (2017-01-30 10:51:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664683003/20001
3 years, 10 months ago (2017-01-30 11:19:58 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 11:51:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8b6fa9d519fb4af611d91cc2c896532147e...

Powered by Google App Engine
This is Rietveld 408576698