Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2664623002: Upstream an assortment of IndexedDB tests to WPT. (Closed)

Created:
3 years, 10 months ago by pwnall
Modified:
3 years, 10 months ago
Reviewers:
jsbell
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org, jsbell+idb_chromium.org, cmumford, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream an assortment of IndexedDB tests to WPT. BUG=683463 Review-Url: https://codereview.chromium.org/2664623002 Cr-Commit-Position: refs/heads/master@{#447038} Committed: https://chromium.googlesource.com/chromium/src/+/20284591559eced2cc3ec539b580cfdca461447a

Patch Set 1 : Moar tests. #

Patch Set 2 : Rebase MANIFEST.json. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -320 lines) Patch
A + third_party/WebKit/LayoutTests/external/wpt/IndexedDB/error-attributes.html View 2 chunks +8 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor-advance-exception-order.html View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbindex-getAll-enforcerange.html View 1 chunk +6 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbindex-getAllKeys-enforcerange.html View 1 chunk +6 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore-getAll-enforcerange.html View 1 chunk +6 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore-getAllKeys-enforcerange.html View 1 chunk +6 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/IndexedDB/open-request-queue.html View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/IndexedDB/support.js View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json View 1 11 chunks +71 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/error-attributes.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-advance-exception-order.html View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/idbindex-getAll-enforcerange.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/idbindex-getAllKeys-enforcerange.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/idbobjectstore-getAll-enforcerange.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/idbobjectstore-getAllKeys-enforcerange.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/open-request-queue.html View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
pwnall
PTAL? The only non-trivial thing here is the expect() function added to support.js. This is ...
3 years, 10 months ago (2017-01-28 08:30:10 UTC) #7
jsbell
lgtm We can always rename expect() later if a true conflict emerges.
3 years, 10 months ago (2017-01-30 17:54:51 UTC) #12
pwnall
On 2017/01/30 17:54:51, jsbell wrote: > lgtm > > We can always rename expect() later ...
3 years, 10 months ago (2017-01-30 18:26:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664623002/40001
3 years, 10 months ago (2017-01-30 18:26:51 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 19:38:17 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/20284591559eced2cc3ec539b580...

Powered by Google App Engine
This is Rietveld 408576698