Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2664573002: Convert ChromePasswordManagerClient to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
vabr (Chromium), dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ChromePasswordManagerClient to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2664573002 Cr-Commit-Position: refs/heads/master@{#446820} Committed: https://chromium.googlesource.com/chromium/src/+/ac485f81fdf1bb3c16921cd3e69cc89370f01c6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
jam
3 years, 10 months ago (2017-01-27 21:20:07 UTC) #5
vabr (Chromium)
LGTM, thanks! Vaclav
3 years, 10 months ago (2017-01-27 22:39:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664573002/1
3 years, 10 months ago (2017-01-27 23:05:57 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 23:16:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac485f81fdf1bb3c16921cd3e69c...

Powered by Google App Engine
This is Rietveld 408576698