Source/modules/mediasource/SourceBuffer.idl - Issue 266453005: Apply TypeChecking to MediaSource IDLs

Unified Diff: Source/modules/mediasource/SourceBuffer.idl

Issue 266453005: Apply TypeChecking to MediaSource IDLs (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Undo too eager removal; Fixup test; Mark remove() args unrestricted. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/mediasource/SourceBuffer.idl

diff --git a/Source/modules/mediasource/SourceBuffer.idl b/Source/modules/mediasource/SourceBuffer.idl

index 1272771cac3f980fe823627b57048461783bc8d8..939c440a7053aa45403c68c4f8d813989be584a4 100644

--- a/Source/modules/mediasource/SourceBuffer.idl

+++ b/Source/modules/mediasource/SourceBuffer.idl

@@ -36,7 +36,8 @@ enum AppendMode {

[

NoInterfaceObject,

Nils Barth (inactive) 2014/05/01 01:08:46 While you're here, could you alphabetize this? Tha

ActiveDOMObject,

- RuntimeEnabled=MediaSource

+ RuntimeEnabled=MediaSource,

+ TypeChecking=Interface|Nullable|Unrestricted,

] interface SourceBuffer : EventTarget {

// Gets or sets the AppendMode.

@@ -55,7 +56,7 @@ enum AppendMode {

[RaisesException=Setter] attribute double appendWindowStart;

// Presentation timestamp for the end of append window.

- [RaisesException=Setter] attribute double appendWindowEnd;

+ [RaisesException=Setter] attribute unrestricted double appendWindowEnd;

// Append segment data.

[RaisesException] void appendBuffer(ArrayBuffer data);

@@ -65,6 +66,6 @@ enum AppendMode {

// Abort the current segment append sequence.

[RaisesException] void abort();

- [RaisesException] void remove(double start, double end);

+ [RaisesException] void remove(unrestricted double start, unrestricted double end);

acolwell GONE FROM CHROMIUM 2014/04/30 17:28:28 start should not be unrestricted. end could be unr

Nils Barth (inactive) 2014/05/01 01:08:46 Fredrik, could you link to the W3 bug? https://www

fs 2014/05/02 09:26:26 Ok. Removed 'unrestricted' again (for the time bei

};