Apply TypeChecking to MediaSource IDLs

Source/modules/mediasource/SourceBuffer.idl

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
  *     * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 

[Nils Barth (inactive), 2014/05/01 01:08:46]

While we're here, could you add a link to the spec?
https://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html...

If you prefer, the published one:
http://www.w3.org/TR/media-source/#idl-def-SourceBuffer
...but we're generally tracking ED, not CR, right?

 enum AppendMode {
     "segments",
     "sequence"
 };
 
 [
     NoInterfaceObject,

[Nils Barth (inactive), 2014/05/01 01:08:46]

While you're here, could you alphabetize this?
Thanks!

     ActiveDOMObject,
-    RuntimeEnabled=MediaSource
+    RuntimeEnabled=MediaSource,
+    TypeChecking=Interface|Nullable|Unrestricted,
 ] interface SourceBuffer : EventTarget {
 
     // Gets or sets the AppendMode.
     // FIXME: Remove MediaSourceExperimental once mode attribute is implemented and stabilized. See http://crbug.com/249422.
     [RaisesException=Setter, RuntimeEnabled=MediaSourceExperimental] attribute AppendMode mode;
 
     readonly attribute boolean updating;
 
     // Returns the time ranges buffered.
     [RaisesException=Getter] readonly attribute TimeRanges buffered;
 
     // Applies an offset to media segment timestamps.
     [RaisesException=Setter] attribute double timestampOffset;
 
     // Presentation timestamp for the start of append window.
     [RaisesException=Setter] attribute double appendWindowStart;
 
     // Presentation timestamp for the end of append window.
-    [RaisesException=Setter] attribute double appendWindowEnd;
+    [RaisesException=Setter] attribute unrestricted double appendWindowEnd;
 
     // Append segment data.
     [RaisesException] void appendBuffer(ArrayBuffer data);
     [RaisesException] void appendBuffer(ArrayBufferView data);
 
     [RaisesException, RuntimeEnabled=Stream] void appendStream(Stream stream, optional unsigned long long maxSize);
 
     // Abort the current segment append sequence.
     [RaisesException] void abort();
-    [RaisesException] void remove(double start, double end);
+    [RaisesException] void remove(unrestricted double start, unrestricted double end);

[acolwell GONE FROM CHROMIUM, 2014/04/30 17:28:28]

start should not be unrestricted. end could be unrestricted to allow
POSITIVE_INFINITY but other non-finite values should result in an error. For
now, I'd prefer to keep the IDL as is so that it matches the spec.

[Nils Barth (inactive), 2014/05/01 01:08:46]

Fredrik, could you link to the W3 bug?
https://www.w3.org/Bugs/Public/show_bug.cgi?id=25518

[fs, 2014/05/02 09:26:26]

Ok. Removed 'unrestricted' again (for the time being.) I'll do minimal "damage"
to the tests (the change/semantics doesn't seem entirely unreasonable.)
Added.

 };