Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2664483002: Support sync mojo IPCs to and from bindings running on a sequence.

Created:
3 years, 11 months ago by Sam McNally
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, riju_, jam, timvolodine, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, mlamouri+watch-sensors_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support sync mojo IPCs to and from bindings running on a sequence. BUG=678155

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+657 lines, -64 lines) Patch
M chrome/gpu/gpu_arc_video_service.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/device_sensors/device_sensor_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_mojo_bootstrap.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/sync_handle_registry.cc View 1 2 3 4 5 6 7 8 9 4 chunks +123 lines, -30 lines 0 comments Download
M mojo/public/cpp/bindings/lib/sync_handle_watcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/sync_handle_registry.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/sync_handle_watcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/report_bad_message_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/sync_method_unittest.cc View 17 chunks +511 lines, -19 lines 0 comments Download

Depends on Patchset:

Issue 2608163003 Patch 240001

Messages

Total messages: 38 (38 generated)
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-27 03:30:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/1
3 years, 11 months ago (2017-01-27 03:31:04 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-27 03:34:15 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/143389) ios-simulator on ...
3 years, 11 months ago (2017-01-27 03:34:16 UTC) #4
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-27 04:31:19 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/20001
3 years, 11 months ago (2017-01-27 04:32:18 UTC) #6
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-27 04:47:02 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/40001
3 years, 11 months ago (2017-01-27 04:47:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-27 05:05:45 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/311070)
3 years, 11 months ago (2017-01-27 05:05:46 UTC) #10
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-27 05:17:55 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/60001
3 years, 11 months ago (2017-01-27 05:18:17 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-27 05:44:01 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/221688)
3 years, 11 months ago (2017-01-27 05:44:02 UTC) #14
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-30 21:59:05 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/100001
3 years, 10 months ago (2017-01-30 21:59:39 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-30 22:48:17 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/357506)
3 years, 10 months ago (2017-01-30 22:48:18 UTC) #18
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-31 01:21:22 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/120001
3 years, 10 months ago (2017-01-31 01:22:02 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-31 01:25:02 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/339343) win_chromium_x64_rel_ng on ...
3 years, 10 months ago (2017-01-31 01:25:03 UTC) #22
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-31 01:30:54 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/120001
3 years, 10 months ago (2017-01-31 01:31:21 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-31 04:02:14 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 10 months ago (2017-01-31 04:02:15 UTC) #26
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-31 18:39:13 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/140001
3 years, 10 months ago (2017-01-31 18:39:47 UTC) #28
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-31 18:46:53 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/160001
3 years, 10 months ago (2017-01-31 18:47:40 UTC) #30
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-31 18:49:38 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/180001
3 years, 10 months ago (2017-01-31 18:50:18 UTC) #32
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-31 21:08:59 UTC) #33
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/381351)
3 years, 10 months ago (2017-01-31 21:09:00 UTC) #34
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-01 00:59:32 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664483002/200001
3 years, 10 months ago (2017-02-01 01:00:14 UTC) #36
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-01 01:05:14 UTC) #37
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 01:05:15 UTC) #38 
Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698