Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2608163003: Change single-interface mojo bindings to use SequencedTaskRunner. (Closed)

Created:
3 years, 11 months ago by Sam McNally
Modified:
3 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change single-interface mojo bindings to use SequencedTaskRunner. BUG=678155

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -250 lines) Patch
M chrome/browser/android/vr_shell/non_presenting_gvr_delegate.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/non_presenting_gvr_delegate.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/leveldb/leveldb_service_impl.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M device/generic_sensor/platform_sensor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/generic_sensor/platform_sensor_reader_win.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M device/generic_sensor/sensor_provider_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M device/generic_sensor/sensor_provider_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/wake_lock/wake_lock_service_context.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_mojo_bootstrap.cc View 1 2 13 chunks +16 lines, -16 lines 0 comments Download
M media/base/android/media_codec_loop.h View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/remoting/adaptive_renderer_factory.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/remoting/courier_renderer.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/associated_binding.h View 1 6 chunks +11 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/associated_group_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/associated_interface_ptr.h View 1 5 chunks +14 lines, -14 lines 0 comments Download
M mojo/public/cpp/bindings/associated_interface_request.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/binding.h View 9 chunks +17 lines, -17 lines 0 comments Download
M mojo/public/cpp/bindings/connector.h View 1 2 8 chunks +12 lines, -14 lines 0 comments Download
M mojo/public/cpp/bindings/interface_endpoint_client.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/interface_request.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 1 2 10 chunks +11 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 1 9 chunks +13 lines, -13 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.h View 1 2 11 chunks +21 lines, -23 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 1 2 27 chunks +37 lines, -35 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/e2e_perftest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 1 2 chunks +44 lines, -32 lines 0 comments Download
A mojo/public/cpp/bindings/tests/thread_per_task_sequenced_task_runner.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/tests/thread_per_task_sequenced_task_runner.cc View 1 1 chunk +136 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/thread_safe_interface_ptr.h View 1 6 chunks +9 lines, -9 lines 0 comments Download
M mojo/public/cpp/system/watcher.h View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/public/cpp/system/watcher.cc View 1 2 4 chunks +10 lines, -8 lines 0 comments Download
M services/device/device_service.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M services/device/device_service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/file/file_service.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M services/file/file_service.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M services/service_manager/public/cpp/binder_registry.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/interface_registry.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/service_manager/public/cpp/lib/callback_binder.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 59 (55 generated)
Sam McNally
3 years, 11 months ago (2017-01-04 09:22:50 UTC) #34
Ken Rockot(use gerrit already)
rs lgtm
3 years, 11 months ago (2017-01-04 22:47:13 UTC) #37
Ken Rockot(use gerrit already)
not lgtm based on discussion with yuzhu
3 years, 11 months ago (2017-01-04 23:05:41 UTC) #38
Ken Rockot(use gerrit already)
3 years, 11 months ago (2017-01-04 23:11:39 UTC) #39
On 2017/01/04 at 23:05:41, Ken Rockot wrote:
> not lgtm based on discussion with yuzhu

(we can discuss in meeting) :)

Powered by Google App Engine
This is Rietveld 408576698