Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Issue 2664463002: DevTools: Turn pie chart into a donut chart. (Closed)

Created:
3 years, 10 months ago by alph
Modified:
3 years, 10 months ago
Reviewers:
paulirish, chowse, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Turn pie chart into a donut chart. BUG=685904 Review-Url: https://codereview.chromium.org/2664463002 Cr-Commit-Position: refs/heads/master@{#446892} Committed: https://chromium.googlesource.com/chromium/src/+/ac21de591dc92f7b4cae71e5a4afd62738344a5e

Patch Set 1 #

Patch Set 2 : tweak idle color #

Patch Set 3 : fix ESLint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/perf_ui/PieChart.js View 1 2 2 chunks +19 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
alph
3 years, 10 months ago (2017-01-27 02:40:09 UTC) #2
paulirish
lgtm
3 years, 10 months ago (2017-01-27 02:45:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664463002/1
3 years, 10 months ago (2017-01-27 18:53:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664463002/20001
3 years, 10 months ago (2017-01-27 19:17:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/379884)
3 years, 10 months ago (2017-01-27 21:54:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664463002/30001
3 years, 10 months ago (2017-01-27 21:59:55 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/222323)
3 years, 10 months ago (2017-01-27 23:47:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664463002/30001
3 years, 10 months ago (2017-01-28 01:04:41 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 03:04:25 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/ac21de591dc92f7b4cae71e5a4af...

Powered by Google App Engine
This is Rietveld 408576698